Only exit zoom out on double clicking the section itself #65782
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
getdave
added
[Type] Bug
|
Size Change: +17 B (0%) Total Size: 1.77 MB
ℹ️ View Unchanged
|
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
This could probably land in 6.7 and not have any side effects. |
talldan
reviewed
Oct 1, 2024
| @@ -113,7 +113,7 @@ export function useBlockProps( props = {}, { __unstableIsHtml } = {} ) { | |||
| useBlockRefProvider( clientId ), | |||
| useFocusHandler( clientId ), | |||
| useEventHandlers( { clientId, isSelected } ), | |||
| useZoomOutModeExit( { editorMode } ), | |||
| useZoomOutModeExit( { clientId, editorMode } ), | |||
There was a problem hiding this comment.
Looks like editorMode is dropped in #65326, so this probably needs a rebase.
talldan
reviewed
Oct 1, 2024
Comment on lines
+35
to
+44
| const sectionsClientIds = getBlockOrder( getSectionRootClientId() ); | ||
|
|
||
| const isSectionBlock = sectionsClientIds.includes( clientId ); |
There was a problem hiding this comment.
I guess in the future this could use the isSectionBlock selector, but it seems incompatible with zoom out mode right now because it checks for navigation mode.
There was a problem hiding this comment.
That selector should be mode agnostic surely? I'll take a look at that.
There was a problem hiding this comment.
I guess the selector is saying that there are no section blocks when in a mode that doesn't support sections.
When looked at that way zoom out could be included in part of the selector's logic.
The selector does also include a few other clauses, so would need to also check they don't introduce edge cases for zoom out.
talldan
approved these changes
Oct 1, 2024
|
Yes this feature really needs some e2e tests 🙏 Shall we open and Issue and scope some out and then write them. I'm thinking a few high level tests to validate key functionality. |
Sounds good. I can make one and then we can split up the tasks of writing the tests once some basic tests are in place. edit: here's an issue - #65797 |
getdave
force-pushed
the
fix/double-click-to-exit
branch
from
0ae7c03 to
8855e20
Compare
getdave
requested review from
ajitbohra,
ntwb,
nerrad,
adamziel,
kevin940726,
tellthemachines,
artemiomorales,
juanmaguitar,
fabiankaegy and
ndiego
as code owners
|
Sorry for the pings. I managed to break everything with a bad rebase! |
getdave
removed request for
ajitbohra,
nerrad,
ellatrix,
ndiego,
artemiomorales,
kevin940726,
tellthemachines and
fabiankaegy
getdave
force-pushed
the
fix/double-click-to-exit
branch
from
8855e20 to
8fc57ed
Compare
getdave
force-pushed
the
fix/double-click-to-exit
branch
from
8fc57ed to
3f1ed6c
Compare
|
Ah...I rebased from |
getdave
force-pushed
the
fix/double-click-to-exit
branch
from
3f1ed6c to
6458b58
Compare
# Conflicts: # packages/block-editor/src/components/block-list/use-block-props/index.js # packages/block-editor/src/components/block-list/use-block-props/use-zoom-out-mode-exit.js
getdave
force-pushed
the
fix/double-click-to-exit
branch
from
6458b58 to
250477f
Compare
|
Ok this is no longer working. Going to close and try again. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Fixes Zoom Out so that only double clicking on the section block itself will exit Zoom Out mode.
Based on #65702
Closes #65750.
Why?
See #65750
Previously clicking on any block would exit Zoom Out unexpectedly. Now only section blocks handle the event.
How?
Testing Instructions
Testing Instructions for Keyboard
Screenshots or screencast
Screen.Capture.on.2024-10-01.at.11-06-33.mp4