fix: Avoid unsupported Gallery MenuGroup usage #63953
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `MenuGroup` and `MenuItem` components are currently undefined for the native mobile editor. Therefore, we cannot render them in code shared between web and native without platform conditionals. Ideally, we add proper support for the native platform to avoid these conditionals, and their complexity and bundle size increase.
dcalhoun
added
[Type] Bug
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: +25 B (0%) Total Size: 1.76 MB
ℹ️ View Unchanged
|
akasunil
merged commit 0bf1cac
into
update/gallery-block-image-link-control
68 checks passed
akasunil
added a commit
that referenced
this pull request
Jul 30, 2024
* Move link dropdown to toolbar in gallery block * Update e2e test for gallery block's setting * Fix e2e test for gallery block images link setting * Fix unit test * Synced with trunk * Added ToolbarDropdownMenu component instead of DropdownMenu * remove remove extra padding around link icon * Remove unused components * Revert "Synced with trunk" This reverts commit 0c7a78b. * Improve snackbar notices for gallery block link control select * Add constant for lightbox option in link control for gallery block * Update getHrefAndDestination function to handle Link control value change for lightbox option * Add lightbox option in link control of gallery block * Add info text for lightbox option in link control for gallery block * Set info text for lightbox option in single line * reverting expand of click option changes * add change to resolve conflict * fix: Avoid unsupported Gallery MenuGroup usage (#63953) The `MenuGroup` and `MenuItem` components are currently undefined for the native mobile editor. Therefore, we cannot render them in code shared between web and native without platform conditionals. Ideally, we add proper support for the native platform to avoid these conditionals, and their complexity and bundle size increase. * removing lightbox changes from edit component of gallery block * Removing unneccessory class * Update link control lable in gallery block * Update label in unit test * Update text in snapshot --------- Unlinked contributors: randomburner, RCNeil. Co-authored-by: akasunil <[email protected]> Co-authored-by: dcalhoun <[email protected]> Co-authored-by: t-hamano <[email protected]> Co-authored-by: madhusudhand <[email protected]> Co-authored-by: artemiomorales <[email protected]> Co-authored-by: paaljoachim <[email protected]> Co-authored-by: luisherranz <[email protected]> Co-authored-by: richtabor <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Avoid rendering components unsupported by native mobile editor within code shared by both web and native.
Why?
The
MenuGroupandMenuItemcomponents are currently undefined for the native mobile editor. Therefore, we cannot render them in code shared between web and native without platform conditionals. Ideally, we add proper support for the native platform to avoid these conditionals, and their complexity and bundle size increase.How?
Wrap changes proposed in #62762 with platform conditionals.
Testing Instructions
Testing Instructions for Keyboard
N/A, no user-facing keyboard changes.
Screenshots or screencast
N/A, no user-facing changes.