Update 'Front page' badge #63752
Merged
Update 'Front page' badge #63752
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jameskoster
added
[Type] Enhancement
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: +25 B (0%) Total Size: 1.75 MB
ℹ️ View Unchanged
|
12 tasks
|
This works as expected, but I do note that it's a tad strange we have "Homepage" and "Posts page".
|
|
I find "Posts page" somewhat unintuitive in isolation, but that's how the page is referred to in reading settings. I don't know that we should diverge from that without updating holistically – that can make things more confusing. I also don't think it should hold up the change in this PR? Or are you saying it's strange to mark this page at all? |
|
No, just the semantics of "Post page" verses the one-word "Homepage". Perhaps worth revisiting "Homepage" to "Home page", but not a big deal. Let's get this in as it does clear things up a bit. |
|
I would advise we revisit 'Home page' to be similar to 'Posts Page' as a fix going forward. I also think we need to check what translation implication 'home' has perhaps? |
|
If so, it should probably be done holistically, capturing UIs such as this one: 
|
|
Yes, that's why it's not changed here-to map to the label provided in core. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Discussed in #56244
This PR does two things:
Testing instructions