Site Title: Add border block support #63631
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akasunil
added
[Type] Enhancement
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
There was a problem hiding this comment.
Thanks for working on this @akasunil 👍
This tests well for me.
Screen.Recording.2024-07-17.at.5.00.35.PM.mp4
The only thing I think we might need is the adoption of the box-sizing: border-box for more consistent size/styling of the block. It seems like adoption of this is pretty inconsistent across blocks at the moment, so I'd like to get some second opinions.
…add/sitetitle-border-support
|
Size Change: +6.68 kB (+0.38%) Total Size: 1.76 MB
ℹ️ View Unchanged
|
Thanks for the ping! Adding the border-box rule sounds consistent with other similar blocks, e.g. the post title block where it was introduced when padding support was added back in: #43457. The site title padding support was added way back in #31125 so has been around for a long time. Are there any concerns that adding box-sizing at this stage could affect sites out in the wild? If so, one option could be to guard the rule so it only applies if a border is present. That said, it feels more like a fix to me to add in the rule. I'll just ping @carolinan for visibility on this one as Carolina introduced padding for this block originally and might have thoughts on the matter. |
Agreed.
I think it would have to be a rather small edge case where the site title block is given an explicit width or inherits one from its parent only to have padding pushing its effective width wider. |
aaronrobertshaw
approved these changes
Jul 30, 2024
There was a problem hiding this comment.
This is testing well for the adoption of border support 👍
✅ Global border styles apply correctly
✅ Block instance styles override global styles
✅ Box sizing takes into account border when parent enforces width
I restored the specificity for the inner link rule as the recent change in selector accidentally bumped it from 0-1-0 to 0-1-1.
Screen.Recording.2024-07-30.at.6.10.39.PM.mp4
97 tasks
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Add border block support to the
Site Titleblock.Part of #43247
Why?
Site Titleblock is missing border support.How?
Adds the border block support in block.json
Testing Instructions
Site Titleblock's border is configurable via Global StylesSite Titleblock and Apply the border stylesScreenshots or screencast
In backend:
In frontend: