DataViews: Replace supportedLayouts prop with defaultLayouts prop instead #63287
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
youknowriad
added
[Type] Enhancement
youknowriad
requested review from
oandregal,
ellatrix,
jorgefilipecosta and
ntsekouras
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: +41 B (0%) Total Size: 1.76 MB
ℹ️ View Unchanged
|
ntsekouras
reviewed
Jul 9, 2024
ntsekouras
reviewed
Jul 9, 2024
| @@ -61,7 +61,7 @@ export function filterSortAndPaginate< Item >( | |||
| } ); | |||
| } | |||
|
|
|||
| if ( view.filters?.length > 0 ) { | |||
| if ( view.filters && view.filters?.length > 0 ) { | |||
There was a problem hiding this comment.
I made view.filters optional that way folks don't have to define it if they don't have filters.
There was a problem hiding this comment.
Yeah, I meant why the previous view.filters?.length wasn't enough..
ntsekouras
approved these changes
Jul 9, 2024
huubl
pushed a commit
to huubl/gutenberg
that referenced
this pull request
Jul 10, 2024
…tead (WordPress#63287) Co-authored-by: youknowriad <[email protected]> Co-authored-by: ntsekouras <[email protected]>
carstingaxion
pushed a commit
to carstingaxion/gutenberg
that referenced
this pull request
Jul 18, 2024
…tead (WordPress#63287) Co-authored-by: youknowriad <[email protected]> Co-authored-by: ntsekouras <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related #55083
What?
Each time we change the "layout" of the DataViews component, we often need to change the fields configuration or tweak the "layout" property of the "view" object... Basically what we're doing here is that we're setting a default value for the "view" object (keeping filters, search...)
Also, on the other hand, when using the DataViews component, we define the "supportedLayouts" prop.
For me, this suggests that these two things are the same and only thing. This PR combines these props in a unique
defaultViewsprop. This is going to be more important with the introduction of field combination as the differences between view types are growing over time.Testing Instructions
This is an API change, but there should be no functional change.