-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Constrain is-fullscreen-mode
admin body class to posts list
#63166
Constrain is-fullscreen-mode
admin body class to posts list
#63166
Conversation
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.
To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Flaky tests detected in ee2a4e3. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/9804072570
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code wise looks okay (with the caveat in my comment). I haven't tested so I'm assuming you've confirmed this still addresses the original reason the code was added.
return "$classes is-fullscreen-mode"; | ||
} | ||
); | ||
if ( isset( $_GET['page'] ) && 'gutenberg-posts-dashboard' === $_GET['page'] ) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What confidence level is there that this route name will remain the same if/when this is ported to WordPress (given the gutenberg
namespace used here). Should page references like this be returned from some sort of central map so that the name can be changed in one place when ported?
For example:
const PAGE_ROUTE_MAP = {
POSTS_DASHBOARD: 'gutenberg-posts-dashboard',
/** ...mapping for other known routes... **/
};
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is just the v1 of posts lists that a GB experiment and we don't know when it's going to be added in core and will have many updates over time. Eventually it will have a specific admin page, where we won't have to do the redirection and these param checks, similar to the site editor page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense. Thanks for the fix!
Co-authored-by: ntsekouras <[email protected]> Co-authored-by: nerrad <[email protected]>
What?
Fixes a bug introduced here: #62705
This PR constrains the
is-fullscreen-mode
admin body class to posts list.