-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Components: upgrade Ariakit to latest #62947
Closed
Closed
Changes from all commits
Commits
Show all changes
43 commits
Select commit
Hold shift + click to select a range
eb40b5f
Upgrade Ariakit to latest.
DaniGuardiola 19a95b2
Revert.
DaniGuardiola e3cfd44
Upgrade in the right package and upgrade "test' too.
DaniGuardiola 430522f
Merge branch 'trunk' of https://github.com/WordPress/gutenberg into u…
DaniGuardiola 50258f0
Upgrade to latest.
DaniGuardiola 79fa288
Pin on v0.3.13 for now.
DaniGuardiola 179f374
Tweaks on two tests.
DaniGuardiola 89f4f17
Merge branch 'trunk' of https://github.com/WordPress/gutenberg into u…
DaniGuardiola cf493d7
Merge branch 'trunk' of https://github.com/WordPress/gutenberg into u…
DaniGuardiola aebd132
Merge branch 'trunk' of https://github.com/WordPress/gutenberg into u…
DaniGuardiola 0c64d63
Replace render method with Ariakit's in custom select control (v1).
DaniGuardiola 3be0bc2
Replace render method with Ariakit's in tabs.
DaniGuardiola 68afa3c
Temporarily copy render utility to repo to experiment with it.
DaniGuardiola bac4026
Add rerender support to `render`.
DaniGuardiola 11a2492
Updated Tabs tests to use new re-render API.
DaniGuardiola f8ada30
Revert manual fixes and fix one of the test files.
DaniGuardiola 375c5ca
Fix test file by switching to Ariakit's render utility.
DaniGuardiola 3e8fa49
Remove accidentally pushed code (oops).
DaniGuardiola f4f5cb9
Fix remaining custom-select-control (v1) tests.
DaniGuardiola 38383d1
Fix remaining font-size-picker tests.
DaniGuardiola ba36ad0
Upgrade `@ariakit/test` to latest.
DaniGuardiola b6627b1
Upgrade to 0.3.14
DaniGuardiola 7e7cb32
Upgrade to 0.4.0
DaniGuardiola 49a959f
Fix CustomSelectControl tests
tyxla 4c022ed
Revert "Fix CustomSelectControl tests"
DaniGuardiola 30a8c1f
Added TODO notes to Tooltip tests.
DaniGuardiola 1637baa
Added TODO notes to CustomSelectControl v2 tests and styles.
DaniGuardiola 28307fe
Added TODO notes to ToggleGroupControl tests.
DaniGuardiola ee85f1a
Added TODO notes to DropdownMenu v2 tests and styles.
DaniGuardiola 246c6dd
Added TODO notes to CustomSelectControl tests.
DaniGuardiola 114badd
Added TODO notes to Composite (legacy) tests.
DaniGuardiola 6679cc6
Fixed all issues and updated snapshots.
DaniGuardiola d2e08e3
Upgrade to 0.4.1
DaniGuardiola 31ad777
Undo temporary hack.
DaniGuardiola bbfb8b1
Upgrade to 0.4.2
DaniGuardiola 2355a34
Upgrade to 0.4.3
DaniGuardiola 91b4b66
Upgrade to 0.4.4
DaniGuardiola d1aab2c
Upgrade to 0.4.5
DaniGuardiola 6ed775d
Upgrade to 0.4.6
DaniGuardiola 3e90c1b
Temporarily revert all deps changes
DaniGuardiola bbd1f11
Merge branch 'trunk' of https://github.com/WordPress/gutenberg into u…
DaniGuardiola 157479d
Restore from latest trunk
DaniGuardiola c32b9a0
Upgrade to 0.4.7 (and 0.3.16 for ariakit/test) cleanly
DaniGuardiola File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With the new render function, could we actually remove the
renderAndValidate
utility in this file?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Potentially!