Inserter: Auto-close the inserter unless the zoom out experiment is on. #61856
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +55 B (0%) Total Size: 1.74 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in b1bf7b8. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/9189199876
|
scruffian
added
[Type] Enhancement
scruffian
changed the title
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
And doesn't auto-close when inserting patterns. When zoomed out, it's great. Without zoom out, it's unexpected (as it covers content). |
|
My brain crashed at "only always" 😆 Remind me again why we completely hide zoom out when opening patterns, instead of just removing the restrictions around section selection etc.? |
The main reasons are:
|
scruffian
changed the title
draganescu
approved these changes
May 22, 2024
|
@scruffian I meant: why not just zoom out the canvas without any other changes (when patterns is open). Same as editor mode, but just scaling the canvas. |
carstingaxion
pushed a commit
to carstingaxion/gutenberg
that referenced
this pull request
Jun 4, 2024
…is on (WordPress#61856) Co-authored-by: scruffian <[email protected]> Co-authored-by: draganescu <[email protected]> Co-authored-by: richtabor <[email protected]> Co-authored-by: ellatrix <[email protected]>
patil-vipul
pushed a commit
to patil-vipul/gutenberg
that referenced
this pull request
Jun 17, 2024
…is on (WordPress#61856) Co-authored-by: scruffian <[email protected]> Co-authored-by: draganescu <[email protected]> Co-authored-by: richtabor <[email protected]> Co-authored-by: ellatrix <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This reverts the change in #61004 and hides it behind the experiment flag.
Why?
This is necessary because without zoom out mode on, the pattern selector overlaps the canvas:
The solution to this is to move the pattern categories inside the drill down as proposed in #61518, but this PR has hit some blockers, so for now I suggest we revert the behaviour.
How?
We output different wrappers for the inserter depending on whether the experiment is enabled.
Testing Instructions