Move default redering mode setting to block_editor_settings_all hook in PHP to allow customizing it
#61844
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…in PHP to allow customizing it
fabiankaegy
added
[Type] Enhancement
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
This pull request has changed or added PHP files. Please confirm whether these changes need to be synced to WordPress Core, and therefore featured in the next release of WordPress. If so, it is recommended to create a new Trac ticket and submit a pull request to the WordPress Core Github repository soon after this pull request is merged. If you're unsure, you can always ask for help in the #core-editor channel in WordPress Slack. Thank you! ❤️ View changed files❔ lib/block-editor-settings.php |
|
Size Change: -17 B (0%) Total Size: 1.75 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in 8e35248. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/9186719342
|
|
I understand the reason for this, but I'm not sure I agree with the solution personally. For instance I don't think all CPTs from the site editor should have the same default rendering mode. I personally would prefer a CPT property instead (like we do for template) |
|
@youknowriad I agree with the fact that it should be a property of the post types. Looking at the They may be a property of the post type. But they get piped to the editor via the block editor settings hook. So I think this PR is the first step of getting us there :) |
|
I think using block editor settings hook for this is not the right thing (and it's not the right thing for template/templateLock either but it's history now :P). Can we instead add these properties to the the post types REST API instead? |
ellatrix
reviewed
May 22, 2024
| @@ -0,0 +1,3 @@ | |||
| https://github.com/WordPress/wordpress-develop/pull/6601 | |||
|
|
|||
| * https://github.com/WordPress/gutenberg/pull/61844 | |||
This was referenced Jun 4, 2024
|
Closing in favor of #62304 |
fabiankaegy
deleted the
feature/add-ability-to-change-default-template-rendering-mode
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Moves the
defaultRenderingModeproperty from being hardcoded in JS to being an option set in PHP via theblock_editor_settings_allhook.Why?
To allow extenders to change the default rendering mode for their custom post types.
How?
By moving the property to the
block_editor_settings_allhook.Testing Instructions
To test that this functions properly you can either add your own custom filter on the
block_editor_settings_allhook and modify thedefaultRenderingModethrough that, or you can change this line here:gutenberg/lib/block-editor-settings.php
Line 149 in 9ef296a