Tweak contextual block toolbar position #61836
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richtabor
added
[Type] Enhancement
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: -5 B (0%) Total Size: 1.75 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in e38b216. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/9180780931
|
|
Hah, this is such a small change yet I feel like it's a huge change. I'm personally drawn to going the other direction: 12px between parent button and toolbar. The toolbar itself is 48px tall, which is a base-12 size, and so 12px spacing harmonizes with that. But it's not a hill I'll die on, and if someone else approves this PR I'll not be crushed. 🙂 |
t-hamano
reviewed
May 22, 2024
The advantage being in your screenshot you can better make out the previous line of text. 🤔 |
t-hamano
approved these changes
May 23, 2024
|
Let's give this a try. |
carstingaxion
pushed a commit
to carstingaxion/gutenberg
that referenced
this pull request
Jun 4, 2024
patil-vipul
pushed a commit
to patil-vipul/gutenberg
that referenced
this pull request
Jun 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Moves the toolbar a closer to the content selected. Originally explored as part of #60286.
Testing Instructions
Screenshots or screencast