Adjust pattern list items resting, hover, focus styles #61831
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richtabor
added
[Type] Enhancement
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: -21 B (0%) Total Size: 1.74 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in 5c04dec. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/9179617315
|
jasmussen
approved these changes
May 22, 2024
t-hamano
reviewed
May 22, 2024
There was a problem hiding this comment.
In this PR, the focus style of the synced pattern also changes from the purple color to the primary color, which is intentional, right?
If so, the .block-editor-block-patterns-list__list-item-synced class is no longer used, so we should be able to remove it here as well.
t-hamano
reviewed
May 22, 2024
| outline: $border-width solid rgba($black, 0.075); | ||
| outline-offset: -$border-width; | ||
| border-radius: $radius-block-ui; | ||
| transition: outline 0.1s linear; |
There was a problem hiding this comment.
Suggested change
| transition: outline 0.1s linear; | |
| transition: outline 0.1s linear; | |
| @include reduce-motion("transition"); |
Yes, I don't think the focus color of previews should change based on the synced status. Within the canvas it's fine as you're selecting the actual entity, but within the inserter it's an element that adds the pattern/synced pattern. |
richtabor
force-pushed
the
tweak/pattern-list-items
branch
from
5c04dec to
d121df3
Compare
carstingaxion
pushed a commit
to carstingaxion/gutenberg
that referenced
this pull request
Jun 4, 2024
* remove overrides * use outlines * move transition to focus Co-authored-by: richtabor <[email protected]> Co-authored-by: jasmussen <[email protected]> Co-authored-by: t-hamano <[email protected]>
patil-vipul
pushed a commit
to patil-vipul/gutenberg
that referenced
this pull request
Jun 17, 2024
* remove overrides * use outlines * move transition to focus Co-authored-by: richtabor <[email protected]> Co-authored-by: jasmussen <[email protected]> Co-authored-by: t-hamano <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Tweaks to fix the various implementations of pattern list items to have the same resting, hover, and focus styles as other related elements. Also forwards #61518.
Testing Instructions
Screenshots or screencast
Focus state is the admin blue.