Global styles: send theme object to setUserConfig #61805
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: -90 B (-0.01%) Total Size: 1.76 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in fc5da99. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/9475993466
|
|
Thanks mate. Missed one here—this could be simply
Yes 😀 this would be a nice cleanup. I think do it as part of these changes in this PR. |
noisysocks
added
the
Global Styles
Thanks for testing this one. Will do 👍🏻 |
ramonjd
force-pushed
the
update/pass-theme-object-to-set-config
branch
from
18e2d5c to
97d34b2
Compare
…lobal styles. Use the object arg for variations, pushing to global styles from block settings, and reset global styles.
noisysocks
approved these changes
Jun 13, 2024
|
Thanks for helping with this one. 🙇🏻 |
patil-vipul
pushed a commit
to patil-vipul/gutenberg
that referenced
this pull request
Jun 17, 2024
* Instead of destructuring object, just send it. The global styles provider does the work. * Remove unnecessary callback - use state function to set current revision * Allow an object or a function in the setConfig function, which sets global styles. Use the object arg for variations, pushing to global styles from block settings, and reset global styles. Co-authored-by: ramonjd <[email protected]> Co-authored-by: noisysocks <[email protected]>
ellatrix
added
the
Backport to WP 6.7 Beta/RC
|
Adding this code quality PR to be backported to resolve a conflict. |
ellatrix
pushed a commit
that referenced
this pull request
Jun 18, 2024
* Instead of destructuring object, just send it. The global styles provider does the work. * Remove unnecessary callback - use state function to set current revision * Allow an object or a function in the setConfig function, which sets global styles. Use the object arg for variations, pushing to global styles from block settings, and reset global styles. Co-authored-by: ramonjd <[email protected]> Co-authored-by: noisysocks <[email protected]>
|
I just cherry-picked this PR to the wp/6.6-beta-3 branch to get it included in the next release: 55abcaa |
ellatrix
added
Backported to WP Core
ellatrix
pushed a commit
that referenced
this pull request
Jun 18, 2024
* Instead of destructuring object, just send it. The global styles provider does the work. * Remove unnecessary callback - use state function to set current revision * Allow an object or a function in the setConfig function, which sets global styles. Use the object arg for variations, pushing to global styles from block settings, and reset global styles. Co-authored-by: ramonjd <[email protected]> Co-authored-by: noisysocks <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Follow up to #61271
Instead of destructuring object, just send it to the global styles provider callback via
setUserConfig.Props to @noisysocks for catching it, and for giving me pause to discover how trivial the change is.
ShouldsetUserConfigaccept a function and an object?Also,
setUserConfignow accept a function and an object to update user global styles. So,Why?
The global styles provider does the work of splitting the properties into
styles,settingsand_links.Testing Instructions
There should be no regressions in the way global style variations or revisions work.
I'm using Twenty Twenty Four to test.
There should be no JS errors, and the theme styles should apply to the canvas.
2024-05-20.11.12.49.mp4
To test the
setUserConfigarguments:There should be no regressions.