Background image: add support for relative theme path URLs in top-level theme.json styles#61271

Merged

ramonjd merged 25 commits intotrunkfrom add/background-images-top-level-resolved-theme-paths

May 20, 2024

+525-24

Commits on May 20, 2024

This initial commit:
ramonjd
committed
For testing purposes, resolve in get_merged_data - should it be optional? That is, done in the global themes controller and wherever a stylesheet is generated?
ramonjd
committed
Rollback test of imperative method in resolver
ramonjd
committed
Moves resolution of file paths back to theme_json resolver
ramonjd
committed
Backend resolution of theme file URIs for global styles.
ramonjd
committed
Working on revisions
ramonjd
committed
So my linter is working again
ramonjd
committed
Changed the relative link to wp:theme-file-uris
ramonjd
committed
Added some explanatory TODOs
ramonjd
committed
Adding valid link attributes to the _link object.
ramonjd
committed
Added some unit tests for utils
ramonjd
committed
Switching to using file: prefix, which is an established theme.json convention for relative paths to theme assets. E.g., web fonts
ramonjd
committed
Fix linting

andrewserong
authored and
ramonjd
committed
Remove TODO
ramonjd
committed
Update tests
ramonjd
committed
dump var_dump
ramonjd
committed
Check for $theme_json before resolving
ramonjd
committed
be explicit about the background value file:./
ramonjd
committed
Remove unnecessary empty check
ramonjd
committed
Abstracting getting any resolved URI to separate hook
ramonjd
committed
Update lib/class-wp-theme-json-resolver-gutenberg.php

noisysocks
authored and
ramonjd
committed
Update lib/class-wp-theme-json-resolver-gutenberg.php

noisysocks
authored and
ramonjd
committed
Revert useGlobalStyle changes - no longer required given the new hook
ramonjd
committed
Bad revert
ramonjd
committed
Rename wp:theme-file-uris to wp:theme-file
ramonjd
committed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Background image: add support for relative theme path URLs in top-level theme.json styles#61271

Commits on May 20, 2024

This initial commit:

For testing purposes, resolve in get_merged_data - should it be optional? That is, done in the global themes controller and wherever a stylesheet is generated?

Rollback test of imperative method in resolver

Moves resolution of file paths back to theme_json resolver

Backend resolution of theme file URIs for global styles.

Working on revisions

So my linter is working again

Changed the relative link to `wp:theme-file-uris`

Added some explanatory TODOs

Adding valid link attributes to the _link object.

Added some unit tests for utils

Switching to using file: prefix, which is an established theme.json convention for relative paths to theme assets. E.g., web fonts

Fix linting

Remove TODO

Update tests

dump var_dump

Check for $theme_json before resolving

be explicit about the background value file:./

Remove unnecessary empty check

Abstracting getting any resolved URI to separate hook

Update lib/class-wp-theme-json-resolver-gutenberg.php

Update lib/class-wp-theme-json-resolver-gutenberg.php

Revert useGlobalStyle changes - no longer required given the new hook

Bad revert

Rename wp:theme-file-uris to wp:theme-file