Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Components: Assess stabilization of ItemGroup #61060

Draft
wants to merge 2 commits into
base: trunk
Choose a base branch
from
Draft

Components: Assess stabilization of ItemGroup #61060

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f5a9e1f
Remove "experimental" designation for `ItemGroup`
fullofcaffeine Apr 19, 2024
6692276
Add CHANGELOG entry
fullofcaffeine Apr 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions packages/components/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,8 @@

## Unreleased

- `ItemGroup`: Remove "experimental" designation ([#61060](https://github.com/WordPress/gutenberg/pull/61060)).

### Enhancements

- `InputControl`: Add a password visibility toggle story ([#60898](https://github.com/WordPress/gutenberg/pull/60898)).
Expand Down
4 changes: 4 additions & 0 deletions packages/components/src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,8 +97,12 @@ export { default as Icon } from './icon';
export type { IconType } from './icon';
export { default as IconButton } from './button/deprecated';
export {
/**
* @deprecated Import `ItemGroup` instead.
*/
ItemGroup as __experimentalItemGroup,
Item as __experimentalItem,
ItemGroup,
} from './item-group';
export { default as __experimentalInputControl } from './input-control';
export { default as __experimentalInputControlPrefixWrapper } from './input-control/input-prefix-wrapper';
Expand Down
8 changes: 2 additions & 6 deletions packages/components/src/item-group/item-group/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,5 @@
# `ItemGroup`

<div class="callout callout-alert">
This feature is still experimental. “Experimental” means this is an early implementation subject to drastic and breaking changes.
</div>

`ItemGroup` displays a list of `Item`s grouped and styled together.

## Usage
Expand All @@ -12,7 +8,7 @@ This feature is still experimental. “Experimental” means this is an early im

```jsx
import {
__experimentalItemGroup as ItemGroup,
ItemGroup,
__experimentalItem as Item,
} from '@wordpress/components';

Expand Down Expand Up @@ -66,7 +62,7 @@ In the following example, the `<Item />` will render with a size of `small`:

```jsx
import {
__experimentalItemGroup as ItemGroup,
ItemGroup,
__experimentalItem as Item,
} from '@wordpress/components';

Expand Down
2 changes: 1 addition & 1 deletion packages/components/src/item-group/item-group/component.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ function UnconnectedItemGroup(
*
* ```jsx
* import {
* __experimentalItemGroup as ItemGroup,
* ItemGroup,
* __experimentalItem as Item,
* } from '@wordpress/components';
*
Expand Down
8 changes: 2 additions & 6 deletions packages/components/src/item-group/item/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,5 @@
# `Item`

<div class="callout callout-alert">
This feature is still experimental. “Experimental” means this is an early implementation subject to drastic and breaking changes.
</div>

`Item` is used in combination with `ItemGroup` to display a list of items grouped and styled together.

## Usage
Expand All @@ -12,7 +8,7 @@ This feature is still experimental. “Experimental” means this is an early im

```jsx
import {
__experimentalItemGroup as ItemGroup,
ItemGroup,
__experimentalItem as Item,
} from '@wordpress/components';

Expand Down Expand Up @@ -50,7 +46,7 @@ In the following example, the `<Item />` will render with a size of `small`:

```jsx
import {
__experimentalItemGroup as ItemGroup,
ItemGroup,
__experimentalItem as Item,
} from '@wordpress/components';

Expand Down
2 changes: 1 addition & 1 deletion packages/components/src/item-group/item/component.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ function UnconnectedItem(
*
* ```jsx
* import {
* __experimentalItemGroup as ItemGroup,
* ItemGroup,
* __experimentalItem as Item,
* } from '@wordpress/components';
*
Expand Down
2 changes: 1 addition & 1 deletion packages/components/src/item-group/stories/index.story.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ const meta: Meta< typeof ItemGroup > = {
component: ItemGroup,
// @ts-expect-error - See https://github.com/storybookjs/storybook/issues/23170
subcomponents: { Item },
title: 'Components (Experimental)/ItemGroup',
title: 'Components/ItemGroup',
argTypes: {
as: { control: { type: null } },
children: { control: { type: null } },
Expand Down
5 changes: 4 additions & 1 deletion storybook/manager-head.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,9 @@
<script>
( function redirectIfStoryMoved() {
const PREVIOUSLY_EXPERIMENTAL_COMPONENTS = [ 'navigation' ];
const PREVIOUSLY_EXPERIMENTAL_COMPONENTS = [
'navigation',
'itemgroup',
];
const REDIRECTS = [
{
from: /\/components-deprecated-/,
Expand Down
Loading