Only close inserter on Escape or button press on inserter toggle #60391
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: +49 B (0%) Total Size: 1.75 MB
ℹ️ View Unchanged
|
|
This is interesting. It's growing on me, especially now that the patterns categories do not cover up your content (in the site editor). |
|
I feel like this should behave (and maybe share code) exactly like the list view. Can we add a close button like the list view? |
|
Warning: Type of PR label mismatch To merge this PR, it requires exactly 1 label indicating the type of PR. Other labels are optional and not being checked here.
Read more about Type labels in Gutenberg. Don't worry if you don't have the required permissions to add labels; the PR reviewer should be able to help with the task. |
|
I would echo that this is functioning well. The Esc to close feels like a smaller step away from the modal behavior we have at the moment. Here's a GIF showing the behavior:
In that GIF:
|
jeryj
force-pushed
the
try/no-autoclose-inserter
branch
from
c97eb2c to
148541d
Compare
scruffian
force-pushed
the
try/no-autoclose-inserter
branch
from
fd069c3 to
bf8f690
Compare
|
Trying out a larger refactor of the inserter tab panels here: #61048 |
Remove the useDialog hook, as it was only used for focus outside and escape keypresses to close the inserter. It doesn't appear any semantics were added. This manually implements an escape keypress hook to close the inserter when focus is inside the inserter.
scruffian
force-pushed
the
try/no-autoclose-inserter
branch
from
bf8f690 to
9a1ec9c
Compare
|
Closing in favor of #61004 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the useDialog hook, as it was only used for focus outside and escape keypresses to close the inserter. It doesn't appear any semantics were added. This manually implements an escape keypress hook to close the inserter when focus is inside the inserter.
What?
Why?
How?
Testing Instructions
Testing Instructions for Keyboard
Screenshots or screencast