Remove duplicate setting for getPostLinkProps and prefer stable naming
#57535
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
talldan
added
[Type] Code Quality
talldan
changed the title
getPostLinkProps and prefer stable naming
|
Size Change: -34 B (0%) Total Size: 1.69 MB
ℹ️ View Unchanged
|
talldan
deleted the
remove/duplicate-editor-setting-for-get-post-link-props
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Tidys up some code from #57036.
That PR is passing a setting into the editor provider called
getPostLinkProps. In theuseBlockEditorSettingshook, it's being redeclared as__experimentalGetPostLinkProps, which doesn't seem necessary.It's also good to avoid the experimental naming as mentioned in #57036 (comment).
I'd still like to consider making this private if that's possible, as it seems like the kind of API that won't stick around for the long term.
Testing Instructions