Components: replace TabPanel with Tabs in the Editor Preferences Modal
#57293
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
36 tasks
|
Size Change: +1.08 kB (0%) Total Size: 1.69 MB
ℹ️ View Unchanged
|
ciampo
force-pushed
the
tabs-preferences-modal
branch
from
1c9a364 to
d611d6e
Compare
chad1008
force-pushed
the
tabs-preferences-modal
branch
from
d611d6e to
ea48e12
Compare
chad1008
changed the title
TabPanel with Tabs in the Editor Preferences ModalTabPanel with Tabs in the Editor Preferences Modal
chad1008
added
[Type] Enhancement
chad1008
force-pushed
the
tabs-preferences-modal
branch
from
fb52604 to
4f6adf5
Compare
mirka
reviewed
Jan 9, 2024
packages/interface/src/components/preferences-modal-tabs/style.scss
Outdated
Show resolved
Hide resolved
mirka
approved these changes
Jan 10, 2024
packages/interface/src/components/preferences-modal-tabs/style.scss
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Replaces the legacy TabPanel component with the new Tabs component.
Why?
Part of the work outlined in #52997
How?
TabPanelis replaced byTabsand its sub-components.Testing Instructions
trunkTesting Instructions for Keyboard
Screenshots or screencast
tabpanel, then to the General tab itself, then to the Close button.tabpanelitself does not get a tab stop, nor does the wrapper around the contents of the PreferencesModal.Modalcontents wrapper should get a tab stop between the last element in thetabpanelcontenst and the Close button. Effectively, focusing the Close button and pressing Shift+Tab should focus the wrapper. Pressing Shift+Tab should go to the last toggle of the currently displayed options.