Dataviews: Extract to dedicated bundled package #56721
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ntsekouras
added
[Type] Experimental
ntsekouras
requested review from
mcsf,
youknowriad,
oandregal and
jorgefilipecosta
ntsekouras
requested review from
ajitbohra,
ryanwelcher,
juanmaguitar,
fabiankaegy and
ndiego
as code owners
|
Size Change: +280 B (0%) Total Size: 1.72 MB
ℹ️ View Unchanged
|
ntsekouras
force-pushed
the
add/dataviews-package
branch
from
01a7ac3 to
4e75979
Compare
oandregal
reviewed
Dec 1, 2023
oandregal
reviewed
Dec 1, 2023
ntsekouras
commented
Dec 1, 2023
oandregal
reviewed
Dec 1, 2023
| @@ -12,7 +12,7 @@ import { __ } from '@wordpress/i18n'; | |||
| /** | |||
| * Internal dependencies | |||
| */ | |||
| import { unlock } from '../../lock-unlock'; | |||
There was a problem hiding this comment.
Taking this PR as opportunity to organize the code a bit. What would you think of the following src tree?
- actions
- view.js
- item.js
- filters
- index.js (was filters.js before)
- add.js
- reset.js
- summary.js
- layouts
- grid.js
- list.js
- table.js
- utils
- use-debounced-input.js
- constants.js
- dataviews.js
- index.js
- pagination.js
- search.js
- style.scss
There was a problem hiding this comment.
I'm planning to reorganise, but in the follow ups because of the many iterations right now. Is that a blocker for you in this PR?
There was a problem hiding this comment.
Is that a blocker for you in this PR?
Not at all! Just thought it'd be nice given the situation, but I understand your concern about this PR's velocity. Let's revisit after merging if you feel this would take a bit longer to agree upon.
ntsekouras
force-pushed
the
add/dataviews-package
branch
from
abb04dd to
d35ebe4
Compare
youknowriad
reviewed
Dec 2, 2023
youknowriad
reviewed
Dec 2, 2023
| OPERATOR_IN, | ||
| LAYOUT_GRID, | ||
| LAYOUT_TABLE, | ||
| } from '@wordpress/dataviews'; |
There was a problem hiding this comment.
Personally, I'm not a big fan of exporting constants from package but I can live with it for now.
There was a problem hiding this comment.
There are a few things here:
- The string constants can be removed DataViews: do not export strings constants #56754
- The
VIEWS_LAYOUTis used for two things- Detect supports, which also can be removed if we go with this API for the list view/preview DataViews: iterate on list view #56746
- Use the icons in the sidebar. What do we do with this one? Export the icons directly or provide a utility such as
getIconForViewType( viewType )?
youknowriad
reviewed
Dec 2, 2023
youknowriad
approved these changes
Dec 2, 2023
youknowriad
reviewed
Dec 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Part of: #55083
This PR extracts DataViews to a dedicated bundled package. Since there are many iterations on the feature it would be good to land the first version and refine later. By refine I mean exposing some APIs like
getLayout, possibly create a store, etc..Testing Instructions