Global styles revisions: update isResolving flag #56491
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ramonjd
added
[Type] Bug
|
Size Change: +12 B (0%) Total Size: 1.7 MB
ℹ️ View Unchanged
|
This was referenced Nov 24, 2023
|
Flaky tests detected in 38ac376a49add77ecca1dff31141cf1529260a92. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/6975828902
|
ramonjd
changed the title
andrewserong
approved these changes
Nov 24, 2023
|
Thanks for testing so quickly! 🙇🏻 |
This change does that
ramonjd
force-pushed
the
update/global-styles-revisions-is-resolving
branch
from
38ac376 to
6e38cc0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
#56349 updated global styles revisions to use the new getRevisions selector.
Great.
I forgot to also update the
isResolvingflag.This PR does that.
Thanks.
Why?
To make sure
isLoadingreturns the right value in the hook.Testing Instructions
Old skool:
Check that the
isResolvingvalue flips fromtruetofalseduring and after resolution (the revisions have been fetched and stored in state)