Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Slot: add styles prop to bubblesVirtually version #56428

Merged
merged 4 commits into from
Nov 22, 2023
Merged

Slot: add styles prop to bubblesVirtually version #56428

merged 4 commits into from
Nov 22, 2023

Conversation

ciampo
Copy link
Contributor

@ciampo ciampo commented Nov 22, 2023 •
edited
Loading

What?

Add the styles prop to the Slot component when bubblesVirtually is true

Why?

Working on #56041 flagged a need for this

How?

Update the component prop types

@ciampo ciampo requested a review from ajitbohra as a code owner November 22, 2023 10:52
@ciampo ciampo self-assigned this Nov 22, 2023
@ciampo ciampo requested review from torounit, a team and tyxla November 22, 2023 10:52
@ciampo ciampo added [Type] Enhancement A suggestion for improvement. [Package] Components /packages/components labels Nov 22, 2023
@ciampo ciampo mentioned this pull request Nov 22, 2023
Merged
tyxla
tyxla approved these changes Nov 22, 2023
View reviewed changes
Copy link
Member

@tyxla tyxla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good! 🚀

There are a few minor documentation suggestions I have before shipping it.

packages/components/CHANGELOG.md Outdated Show resolved Hide resolved
packages/components/src/slot-fill/types.ts Outdated Show resolved Hide resolved
packages/components/src/slot-fill/types.ts Outdated Show resolved Hide resolved
packages/components/src/slot-fill/types.ts Outdated Show resolved Hide resolved
packages/components/CHANGELOG.md Outdated Show resolved Hide resolved
@ciampo
Copy link
Contributor Author

ciampo commented Nov 22, 2023

Thank you @tyxla , always appreciate your attention to detail!

All feedback should be now addressed, I will merge once all CI tasks have passed successfully.

@ciampo ciampo enabled auto-merge (squash) November 22, 2023 16:20
@ciampo ciampo merged commit 574f628 into trunk Nov 22, 2023
50 checks passed
@ciampo ciampo deleted the feat/slot-fill-types-styles branch November 22, 2023 16:48
@github-actions github-actions bot added this to the Gutenberg 17.2 milestone Nov 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tyxla tyxla tyxla approved these changes

@ajitbohra ajitbohra Awaiting requested review from ajitbohra ajitbohra is a code owner

@torounit torounit Awaiting requested review from torounit

Assignees

@ciampo ciampo

Labels
[Package] Components /packages/components [Type] Enhancement A suggestion for improvement.
Projects
None yet
Milestone
Gutenberg 17.2
Development

Successfully merging this pull request may close these issues.
2 participants
@ciampo @tyxla