Code

Implement Tabs in editor settings#55360

Code

Merged

chad1008 merged 23 commits intotrunkWordPress/gutenberg:trunkfrom tabs-editor-settingsWordPress/gutenberg:tabs-editor-settingsCopy head branch name to clipboardDec 12, 2023

+180-243

Commits

Commits on Dec 8, 2023

• implement Tabs in editor settings sidebar

  chad1008

  committed
  ad8819d

• remove duplicated styles from editor sidebar

  chad1008

  committed
  4cb5c69

• incorporate initial feedback

  chad1008

  committed
  ddd8d7f

• pass props to Tabs directly

  chad1008

  committed
  4142f5a

• add closeGeneralSidebar to onSelect callback

  chad1008

  committed
  b67019b

• set TabPanels to focuasable={false}

  chad1008

  committed
  b9723d7

• detect when sidebar is closed. pass selectedTabId of null

  chad1008

  committed
  1fbbef4

• improve Tabs onSelect callback

  chad1008

  committed
  f3fea72

• remove aria-label and data-label props

  chad1008

  committed
  a01b24c

• add note explaining null selected tab when sidebar is closed

  chad1008

  committed
  2e73939

• update e2e test

  chad1008

  committed
  ed1c930

• style updates

  chad1008

  committed
  4d47b34

• update internal component structure to avoid rerenders

  chad1008

  committed
  1e471ee

• remove fragment

  chad1008

  committed
  9ea4a0e

• prevent infinite loop when opening third party sidebar

  chad1008

  committed
  8e5ad95

• update e2e tests for Tabs compatibility

  chad1008

  committed
  e57f8a1

• fix double top margin on tabpanels

  chad1008

  committed
  8a7b8f1

• update to use new tabId prop

  chad1008

  committed
  c3eb43e

• remove import that is no longer needed after rebase

  chad1008

  committed
  73db1df

• fix keyboard navigable blocks test

  chad1008

  committed
  7fe4d02

• fix visibility and tab order tests

  chad1008

  committed
  4d0c547

• fix footnotes tests

  chad1008

  committed
  10507a2

Commits on Dec 9, 2023

• fix change detection test

  chad1008

  committed
  5d20c8b