Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try: use ariakit for DropdownMenu v2, test it in block editor settings #54612

Closed
wants to merge 11 commits into from
Closed

Try: use ariakit for DropdownMenu v2, test it in block editor settings #54612

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
bfaf7ad
Basic dropdown implementation
ciampo Sep 19, 2023
a985cf4
Export new dropdown components as private APIs via lock/unlock
ciampo Sep 19, 2023
19194e3
add modal storybook example
ciampo Sep 19, 2023
a101e42
Make dropdownmenu modal
ciampo Sep 19, 2023
378f980
WIP
ciampo Sep 19, 2023
10dc98f
Format
ciampo Sep 25, 2023
19192df
Fix modal closing prematurely
ciampo Sep 25, 2023
b4067db
Use custom context to pass menu store around, add nested menu to slot…
ciampo Sep 25, 2023
be13403
Remove temporary modal fix
ciampo Sep 26, 2023
a41674d
Try nested dropdown menu in slotfill
ciampo Sep 26, 2023
967bb13
Use hideOnHoverOutside prop
ciampo Sep 26, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions packages/block-editor/src/components/block-settings-menu-controls/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,8 +72,8 @@ const BlockSettingsMenuControlsSlot = ( {
}

return (
<MenuGroup>
{ showConvertToGroupButton && (
<>
{ /* { showConvertToGroupButton && (
<ConvertToGroupButton
{ ...convertToGroupButtonProps }
onClose={ fillProps?.onClose }
Expand All @@ -83,9 +83,9 @@ const BlockSettingsMenuControlsSlot = ( {
<BlockLockMenuItem
clientId={ selectedClientIds[ 0 ] }
/>
) }
) } */ }
{ fills }
{ fillProps?.canMove && ! fillProps?.onlyBlock && (
{ /* { fillProps?.canMove && ! fillProps?.onlyBlock && (
<MenuItem
onClick={ pipe(
fillProps?.onClose,
Expand All @@ -100,8 +100,8 @@ const BlockSettingsMenuControlsSlot = ( {
clientId={ fillProps?.firstBlockClientId }
onToggle={ fillProps?.onClose }
/>
) }
</MenuGroup>
) } */ }
</>
);
} }
</Slot>
Expand Down
Loading