Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dependabot settings: remove the Automated testing label. #53116

Merged
merged 1 commit into from
Sep 7, 2023

Conversation

priethor
Copy link
Contributor

What?

Updates the dependabot settings to add less labels to PRs.

Why?

Following up on #52760, PRs should only have one label of each type. Moreover, the Automated testing label has been updated to [Type] Automated testing and doesn't exist anymore.

How?

By removing the Automated testing label from the dependabot settings.

@priethor priethor requested review from ockham, mcsf, desrosj and gziolo July 28, 2023 14:43
@priethor priethor added [Type] Project Management Meta-issues related to project management of Gutenberg GitHub Actions Pull requests that update GitHub Actions code labels Jul 28, 2023
Copy link
Contributor

@desrosj desrosj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems fine.

It looks like two [Type] labels are currently being added, automated testing and build tooling (see #51461). It's likely adding what's closest to the inaccuracy being fixed here. For what it's worth, I think GitHub Actions related changes could affect either, or even both. Build Tools will not always be the correct label.

If they're both added, it forces someone to think about which one is more appropriate before removing the second one. Maybe instead of deleting Automated Testing, adjust it to [Type] Automated Testing?

I'm not the person using these labels for anything currently, though. So I defer to you all.

@priethor
Copy link
Contributor Author

priethor commented Aug 7, 2023

Maybe instead of deleting Automated Testing, adjust it to [Type] Automated Testing?

Thanks for the insights, @desrosj ! What triggered me to open this PR is that I have recently renamed Automated testing with the Type prefix, too, as part of #52760, which prevents merging PRs with more than one type of type-related label. The idea was to prevent Dependabot PRs from having two type labels. However, if we are unsure which one applies, as Dependabot PRs still need to be manually approved, we could let the reviewer adjust the labels at their discretion.

Given that you usually review those PRs, would you find that too much of a hassle? I'm happy to close this PR if you prefer that approach 🙂

Copy link
Contributor

@desrosj desrosj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm fine with this for now. There is an error being shown on every Dependabot PR because the label no longer exists.

@desrosj desrosj merged commit 8f3c621 into trunk Sep 7, 2023
@desrosj desrosj deleted the dependabot-update branch September 7, 2023 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
GitHub Actions Pull requests that update GitHub Actions code [Type] Project Management Meta-issues related to project management of Gutenberg
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants