-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Experiment: Auto-inserting block patterns on the frontend #51294
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ockham
added
[Feature] Block API
API that allows to express the block paradigm.
[Type] Technical Prototype
Offers a technical exploration into an idea as an example of what's possible
labels
Jun 7, 2023
Flaky tests detected in 0a07027. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/5200288551
|
This was referenced Jun 8, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
[Feature] Block API
API that allows to express the block paradigm.
[Type] Technical Prototype
Offers a technical exploration into an idea as an example of what's possible
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Spun off from #50103, this PR explores auto-inserting block patterns (rather than just blocks).
Why?
For the rationale of why block patterns might be better suited for auto-insertion, see #50103 (comment). For general auto-inserting concepts, see #39439.
How?
Much like #50103, we use:
render_block
hook to auto-insert a block pattern before or after a given "anchor" block, andrender_block_data
hook (which -- unlike therender_block
hook -- conveniently gives us access to a given block's children) to auto-insert a block pattern as an anchor block's first or last child.In both filters, we iterate over all registered block patterns to find any that specify the current block as their "anchor" block.
To illustrate both concepts, we add:
The latter example is chosen to also demonstrate that block context is successfully passed to auto-inserted blocks (as evidenced by the auto-inserted Avatar blocks showing each comment author's avatar).
Testing Instructions
npm run build
).