-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Shadow: add shadow presets support via theme.json #46813
Conversation
update shadow values fetch the updated core theme.json file update class name of json ressolver
33b5693
to
203d956
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for splitting the work in smaller steps!
I've tested a variety of scenarios: defining the presets in the theme.json
of the theme instead of using the theme.json
bundled by Gutenberg, using the shadow in a block. I've also tested that style variations work the same as the main theme.json
of the theme (needed to merge #46810 into this one). This is ready to ship.
Adds shadow presets support for `theme.json` within the `WP_Theme_JSON` by * Adding it to presets metadata and valid settings. * Defining the default shadow presets in Core's `theme.json`. Includes PHPUnit tests. References: * [WordPress/gutenberg#46813 Gutenberg PR 46813] * [WordPress/gutenberg#47272 Gutenberg PR 47272] Follow-up to [54162], [52049], [50973]. Props madhudollu, mamaduka, oandregal, scruffian, hellofromTonya. Fixes #57559. git-svn-id: https://develop.svn.wordpress.org/trunk@55176 602fd350-edb4-49c9-b593-d223f7449a82
Adds shadow presets support for `theme.json` within the `WP_Theme_JSON` by * Adding it to presets metadata and valid settings. * Defining the default shadow presets in Core's `theme.json`. Includes PHPUnit tests. References: * [WordPress/gutenberg#46813 Gutenberg PR 46813] * [WordPress/gutenberg#47272 Gutenberg PR 47272] Follow-up to [54162], [52049], [50973]. Props madhudollu, mamaduka, oandregal, scruffian, hellofromTonya. Fixes #57559. Built from https://develop.svn.wordpress.org/trunk@55176 git-svn-id: http://core.svn.wordpress.org/trunk@54709 1a063a9b-81f0-0310-95a4-ce76da25c4cd
Adds shadow presets support for `theme.json` within the `WP_Theme_JSON` by * Adding it to presets metadata and valid settings. * Defining the default shadow presets in Core's `theme.json`. Includes PHPUnit tests. References: * [WordPress/gutenberg#46813 Gutenberg PR 46813] * [WordPress/gutenberg#47272 Gutenberg PR 47272] Follow-up to [54162], [52049], [50973]. Props madhudollu, mamaduka, oandregal, scruffian, hellofromTonya. Fixes #57559. Built from https://develop.svn.wordpress.org/trunk@55176 git-svn-id: https://core.svn.wordpress.org/trunk@54709 1a063a9b-81f0-0310-95a4-ce76da25c4cd
Adds shadow presets support for `theme.json` within the `WP_Theme_JSON` by * Adding it to presets metadata and valid settings. * Defining the default shadow presets in Core's `theme.json`. Includes PHPUnit tests. References: * [WordPress/gutenberg#46813 Gutenberg PR 46813] * [WordPress/gutenberg#47272 Gutenberg PR 47272] Follow-up to [54162], [52049], [50973]. Props madhudollu, mamaduka, oandregal, scruffian, hellofromTonya. Fixes #57559. Built from https://develop.svn.wordpress.org/trunk@55176 git-svn-id: http://core.svn.wordpress.org/trunk@54709 1a063a9b-81f0-0310-95a4-ce76da25c4cd
What?
This adds support for default and theme shadow presets via theme.json
It ads following default presets to Gutenberg bundled theme.json
Testing Instructions
--wp--preset--shadow--natural
and--wp--preset--shadow--sharp
in global style sheet.This is a PR to add support via theme.json.
Verify end to end feature including UI in global styles from here #46502
Related issues
Partial Fix for #44651