Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Calendar: Add spacing support #43654

Open
wants to merge 1 commit into
base: trunk
Choose a base branch
from
Open

Calendar: Add spacing support #43654

wants to merge 1 commit into from

Conversation

ndiego
Copy link
Member

@ndiego ndiego commented Aug 26, 2022

Related:

Relies on:

What?

Add padding and margin support to the Calendar block.

Why?

To create consistency across blocks.

How?

Added the relevant block supports in block.json

Testing Instructions

  1. Insert a new Calendar block.
  2. Confirm the Dimension control panel allows you to add both padding and margin.
  3. Adding padding and margin.

⚠️ Note that there is an issue in the Calendar block about how attributes are applied. They actually get applied twice. I have created a separate PR to address this. Once that is merged, this PR should be good to go.

Screenshots or screencast

post-term-spacing

@ndiego ndiego added [Type] Enhancement A suggestion for improvement. [Block] Calendar Affects the Calendar Block [Feature] Design Tools Tools that impact the appearance of blocks both to expand the number of tools and improve the experi labels Aug 26, 2022
@ndiego ndiego self-assigned this Aug 26, 2022
This was referenced Aug 26, 2022
Open
Open
Open
@ramonjd
Copy link
Member

ramonjd commented Sep 5, 2022

This is what I'm seeing for the record.

2022-09-05.15.58.36.mp4

Looking pretty good for when #43653 is baked!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ramonjd ramonjd Awaiting requested review from ramonjd

@andrewserong andrewserong Awaiting requested review from andrewserong

@aaronrobertshaw aaronrobertshaw Awaiting requested review from aaronrobertshaw

@ajitbohra ajitbohra Awaiting requested review from ajitbohra ajitbohra is a code owner

@ryanwelcher ryanwelcher Awaiting requested review from ryanwelcher

@juanmaguitar juanmaguitar Awaiting requested review from juanmaguitar juanmaguitar is a code owner

@fabiankaegy fabiankaegy Awaiting requested review from fabiankaegy fabiankaegy is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

@ndiego ndiego

Labels
[Block] Calendar Affects the Calendar Block [Feature] Design Tools Tools that impact the appearance of blocks both to expand the number of tools and improve the experi [Type] Enhancement A suggestion for improvement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ndiego @ramonjd