-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Post Terms: Add spacing support #43646
Post Terms: Add spacing support #43646
Conversation
// This block has customizable padding, border-box makes that more predictable. | ||
box-sizing: border-box; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ahh, my sloppy mistake. I will correct that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Theme.json, global styles and editing individual blocks work.
When nested, the margins are overriden by the is-layout-constrained
styles.
Meaning that it will not always work, for example in its default position in Twenty Twenty-Two and Twenty Twenty-Three.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @ndiego, this is testing nicely now!
Looks like it'll just need a rebase to get the tests passing before it can be merged.
LGTM! ✨
5cbf629
to
484a0bf
Compare
Sorry for the delay on this. Just rebased and now all checks have passed. 🚢ing |
Related:
What?
Add padding and margin support to the Post Terms block.
Why?
To create consistency across blocks.
How?
Added the relevant block supports in block.json
Testing Instructions
Screenshots or screencast