Add margin and padding supports to Audio block. #43351
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tellthemachines
added
[Block] Audio
tellthemachines
requested review from
ajitbohra,
ryanwelcher,
juanmaguitar and
fabiankaegy
as code owners
There was a problem hiding this comment.
This is generally working well for me, but I noticed that for it to work in an expected way in TwentyTwentyTwto, I needed to add a box-sizing: border-box rule in order for the padding to work, because of the .wp-block-audio classname's width: 100% rule.
Without that, here's how the Audio block sits against a Group block with the same padding setting:
From a quick skim of other block CSS, it looks like most other blocks that implement padding also include a box-sizing: border-box rule. Shall we add it in for this one, too?
It looks like for other blocks, it's included with a comment like this one:
|
Thanks for reviewing @andrewserong ! Yeah, that makes sense, I'll add it in. |
|
Size Change: +146 B (0%) Total Size: 1.24 MB
ℹ️ View Unchanged
|
andrewserong
approved these changes
Aug 18, 2022
There was a problem hiding this comment.
Thanks @tellthemachines, that's working nicely for me now, and the styles appear to be output correctly in global styles, too.
LGTM! ✨
This was referenced Aug 19, 2022
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Addresses part of #43243.
Why?
For consistency of design tools between blocks.
How?
Adds margin and padding supports to Audio block.
Testing Instructions
Screenshots or screencast