Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Page List Block: Add block.json color supports #36590

Open
wants to merge 1 commit into
base: trunk
Choose a base branch
from
Open

Page List Block: Add block.json color supports #36590

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion packages/block-library/src/page-list/block.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,12 @@
],
"supports": {
"reusable": false,
"html": false
"html": false,
"color": {
"background": true,
"link": true,
"text": true
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Page list only ever has links (plus bullet points) so making "link" option available means we can end up with a different colour for the bullet points and for the links:
Screen Shot 2021-11-19 at 10 41 02 am

Which, granted, someone might want to do, but is likely only going to cause confusion. Having only background and text color settings should be enough.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Which, granted, someone might want to do, but is likely only going to cause confusion

Agreed -- this is a good point 👍

Having only background and text color settings should be enough.

Do you happen to mean background + link color settings? I imagine the user would be more worried about changing the color of the text than the bullet point.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The text color setting will change both links and bullets; the link color will only change the links. If I were setting a color on the block, I would expect it to change everything; not sure there's a use case for changing just the links.

}
},
"editorStyle": "wp-block-page-list-editor",
"style": "wp-block-page-list"
Expand Down