Avoid showing deleted records in editor saving flow #36027
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
talldan
added
[Type] Bug
7 tasks
|
Size Change: -1 B (0%) Total Size: 1.08 MB
ℹ️ View Unchanged
|
Do you think we can try this, I feel like it's a "purer" solution and a simple one as well. |
Yep, sure thing. |
7 tasks
@youknowriad It works, until you press 'undo' and then the removed edit is restored. Not sure what the right way to handle that would be. Should it also iterate through the undo stack and remove all edits associated with the deleted entity? I think this is where things get a bit weird when it comes to multi-entity editing. #36030 is the PR with the changes, and I've also updated #35981 to have that fix instead of this one. |
|
It seems there's an "undo" issue regardless of the approach, if the "delete" is effective on the backend, what does undo mean in this case? I guess we can't undo that change. So what solutions do we have there?
|
I feel like this might be better. Anywhere that references a deleted entity should be able to handle it, because it's possible to delete an entity outside of the editor anyway. The UI might just show it as deleted. It wouldn't be possible to undo changes for the deleted entity. But I think it is a bit weird for the user who possibly just perceives the editor as a single document rather than multiple interconnected documents. |
|
@talldan Sure that works for me, in all cases it's better than trunk where all of that is not handled anyway. |
|
@youknowriad Is it possible to merge this as a temporary fix? It seems harmless and can be reverted later on. #36030 is taking a bit longer, and I need to timebox my efforts on it. Unfortunately the entity panel bug is blocking an enhancement that I need to ship. |
youknowriad
approved these changes
Oct 29, 2021
talldan
deleted the
fix/avoid-showing-deleted-entity-records-in-saving-flow
branch
talldan
changed the title
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes an issue I spotted when working on #35981.
If an entity is deleted in an editor, the entity saving panel tries to show it as an
undefinedthing that needs to be saved:Since a delete is immediate, that shouldn't be the case.
This filters the deleted records out of the
__experimentalGetDirtyEntityRecordsby checking if the entity exists usinggetEntityRecord.But there might be a deeper issue. I noticed that the
deleteEntityRecordsdoesn't removeeditsfor an entity record. Should it? That's something I'm unsure of.How has this been tested?
Types of changes
Bug fix (non-breaking change which fixes an issue)
Checklist:
*.native.jsfiles for terms that need renaming or removal).