-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Try: reword navigation color labels. #35916
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasmussen
added
[Type] Copy
Issues or PRs that need copy editing assistance
[Block] Navigation
Affects the Navigation Block
labels
Oct 25, 2021
Size Change: +5 B (0%) Total Size: 1.07 MB
ℹ️ View Unchanged
|
carolinan
approved these changes
Oct 25, 2021
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
[Block] Navigation
Affects the Navigation Block
[Type] Copy
Issues or PRs that need copy editing assistance
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #33640. Before:
After:
There will be a point in the future where the color palettes are collapsed into
ItemGroup
s, at which point the verbiage conversation might resurface (see thoughts and mockups in this comment), but in the mean time, this tiny fix makes the color choices more obvious.How has this been tested?
Insert the navigation block, observe the color panel in the inspector has new labels.
Checklist:
*.native.js
files for terms that need renaming or removal).