Navigation: add transformations from a link to other allowed nav blocks #34978
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gwwar
added
[Type] Enhancement
gwwar
force-pushed
the
try/navigation-link-transform
branch
from
da57ab2 to
0646703
Compare
|
Size Change: +183 B (0%) Total Size: 1.06 MB
ℹ️ View Unchanged
|
7 tasks
gwwar
force-pushed
the
try/navigation-link-transform
branch
from
76310e1 to
ef44be2
Compare
|
My assumptions about transforms were incorrect yesterday. So this one is ready for 👀 We already do some basic filtering when block types are not registered, or if a child block type can't be inserted |
7 tasks
There was a problem hiding this comment.
Thanks for working on this! Code-wise it looks good and it's working well ✅
The one thing I'm not sure about is the transforms from Submenu block to other block types, because in doing that all the submenu children are lost. Users might not realise that happens at first, especially because something like "Home Link" feels like it could easily be a submenu parent too.
In the context of #34041, the requirement is only for Navigation Links to transform to other blocks because the other blocks won't be so easily accessible without the quick inserter, so we could just not add any transforms to Submenus for now. Or if we do want to add those transforms, they should pop up a warning that all the contents of the Submenu will be lost.
Thanks for taking a look @tellthemachines Good thought, I suppose that might be more of a concern in a mega menu. I added an |
tellthemachines
approved these changes
Sep 23, 2021
|
Thanks for the review @tellthemachines ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small part of #34041
This adds to transforms for other navigation blocks (search, home link, social icons, site-logo and spacer.
CleanShot.2021-09-20.at.14.41.46.mp4
TODO
trunkwhen attempting to transform to a submenu. Navigation Editor: avoid crash when transforming navigation link #34980 fixes thisTesting Instructions
npm run buildQuestion: How useful are the Navigation Link Variations?
Specific navigation link variations like a Post Link, Page Link, Category Link (CPT Link) etc feel like they clutter up the inserter and the transformation mechanism is separate from a normal block transform. Since we're interested in simplifying workflows I wonder if we could remove these from being so prominent. 🤔