Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New block: Add a Breadcrumbs block #32500

Open
wants to merge 35 commits into
base: trunk
Choose a base branch
from

Conversation

andrewserong
Copy link
Contributor

@andrewserong andrewserong commented Jun 8, 2021

Description

Related to #21943

This PR proposes adding in a new Breadcrumbs block, to render navigation links of the hierarchy of a page. This is a server rendered block, which would typically be used in a page template, most likely before or after the Post Title.

Features include

  • Markup follows this example: https://www.w3.org/WAI/ARIA/apg/patterns/breadcrumb/examples/breadcrumb/
  • Support for pages (hierarchical post types) or
  • Support for displaying a single hierarchical category as breadcrumbs for posts
  • Set a custom separator character (click on the separator in the editor canvas to edit)
  • Show leading separator (so that the breadcrumb can be rendered like a back button)
  • Show current page / post title
  • Show site title
  • Custom override text to override the site title (click on the site title in the editor canvas to edit)

Some of these features are implemented in a subtle way so as to not be intrusive. To override the site title, once it's displayed as the first breadcrumb, a user can click into the site title and manually update it. Likewise, the separator character defaults to / but can be edited by clicking on it and replacing it with another character.

Testing instructions

  1. Use a block-based theme such as TT3
  2. Open up the site editor and edit a template part that will be used for pages (or any hierarchical post type)
  3. Insert the Breadcrumbs block to the template part so that it's rendered when you view a page on the front end of the site
  4. Note that in the site editor, the block will display placeholder names for each of the breadcrumbs
  5. Create a couple of pages, and assign parents to these pages so that you have nested pages on your site
  6. View the page on the front end of the site, and you should see the Breadcrumbs rendered in the appropriate place in the template

Repeat the above with a normal post, and use hierarchical post types.

If you wish to test the custom block spacing control, be sure to use an FSE theme, and set the settings.spacing.blockGap value to true in your theme.json file (for more information on this see the testing instructions in a blockGap PR like #34630)

Screenshots

image

2023-06-05.14.15.55.mp4

@aristath aristath self-requested a review July 6, 2021 15:04
@andrewserong
Copy link
Contributor Author

Update: I'm still keen to continue developing this block (I switched over to working on some other projects these past few weeks, but hope to keep chipping away at this in my spare time). If anyone has a chance to take a look, I'm keen to get feedback on the approach, and input into some design considerations:

  • Does the approach of this server-rendered block seem okay?
  • At the moment it just deals with hierarchical post types (e.g. pages). It'd be nice for it to also optionally handle hierarchical categories, so that we could use it for a template part that covers normal blog posts.
  • Any ideas on how best to handle / break down the UI for mobile?
  • What about placeholder text in the UI? At the moment if we can't grab real hierarchical post titles in the editor, I'm using some placeholder names so that editing a template part is visually as close to the real thing as we can get. Any ideas for better placeholder names?
  • Should we also offer a selection of icons for the separator, so that we're not limited by characters available in the current font? In the sidebar, I'm imagining a few different icons that the user can click, and an "Other:" option where they can enter a custom character?
  • What color controls do we need at the outset? (E.g. if the current page title is not a link, then we might want to be able to have a different color for the separator versus text color)

Many of these ideas might not be required for an MVP for this block, so I'm happy to hear any ideas!

@andrewserong andrewserong added [Status] In Progress Tracking issues with work in progress and removed [Status] In Progress Tracking issues with work in progress labels Jul 8, 2021
@andrewserong andrewserong self-assigned this Jul 8, 2021
@andrewserong andrewserong force-pushed the try/add-breadcrumbs-block branch from 0bbe814 to ea49cfc Compare July 8, 2021 05:15
@andrewserong
Copy link
Contributor Author

I've given this a rebase and fixed up some linting issues, so this should be good for folks to take for a spin if you'd like to test it out. There's still a bunch of To-do list items (and likely many To-do items that I haven't thought of), so please do let me know if you have ideas on how you think this block should be implemented, or needed features.

@andrewserong andrewserong added the New Block Suggestion for a new block label Jul 8, 2021
@paaljoachim
Copy link
Contributor

Hey @andrewserong

Testing the Gutenberg PR build. This looks really really nice! Great work!

I made 3 nested pages: top page - 2 page - 3 page

Screen Shot 2021-08-17 at 16 54 34

Panels:
Typography
Color
Spacing
Breadcrumbs settings (Should this be called something else? As all the sidebar when Breadcrumbs is selected is Breadcrumbs settings. Not sure what to call it at the moment.)

Nesting level. I am wondering if it should start without the value 0 present (if possible) or a dash - (no value). As I initially read it as Nesting level 0 (meaning no nesting levels). I then read the text: Set to 0 to show all nesting levels.

Nesting level does not show the home page.

Screen Shot 2021-08-17 at 17 12 06

I would assume when selecting Nesting level 0 that the home page would also show.
I would also assume that I can rename the home page breadcrumb link if I want to or use a house icon.

Separator character. When removing / I notice the placeholder says e.g. /
Perhaps it should say: e.g. / -

Perhaps something like this:
Screen Shot 2021-08-17 at 17 07 13

I closed the various panels such as Typography and Spacing. Deselected the Breadcrumbs block and reselected it again. I noticed that Typography and Spacing was open again. I assume there is save mechanism so that when I close/open panels it would remain that way even upon deselecting and reselecting the Breadcrumbs block.

Andrew this is really really nice work! Thank you for working on it!

Btw the block toolbar alignment controls work really well!

I found this interesting resource:
https://semantic-ui.com/collections/breadcrumb.html

@andrewserong
Copy link
Contributor Author

Thanks for the feedback @paaljoachim, great suggestions!

Breadcrumbs settings (Should this be called something else

Yes, I couldn't quite think of a good name for it, either, but even "Breadcrumbs" would be better to drop the superfluous word "settings".

Nesting level does not show the home page.

Good catch, I like the idea of adding that in, and I think you're right, it would be good to handle that implicitly as part of the nesting levels. It might be worth also having a toggle for whether or not to show it? Either way, I like your idea of being able to override the site title / home breadcrumb 👍

Icons would be a cool addition, too, I'm curious how far we can get without introducing icons as a first pass, and perhaps treat icons as an enhancement in a follow-up.

Thanks again for the feedback! I'm mostly focusing on helping out with some of the design tooling at the moment, but will come back to this and chip away at the suggestions here, let me know if you think of any others 🙂

@paaljoachim
Copy link
Contributor

Hey Andrew.

Using the name Breadcrumbs instead of Breadcrumbs settings seems fine (for now anyway).

A toggle to show the home page title seems like a good idea. Then a way to override the site title / home breadcrumb.

Icons would be a cool addition, too, I'm curious how far we can get without introducing icons as a first pass, and perhaps treat icons as an enhancement in a follow-up.

I agree. It sounds like a nice follow-up for a later point.
I am also wondering when talking about icons if adding the icons block #16484 would be helpful for making some icons available in the Breadcrumbs block.

I will let you know of additional suggestions as they show up.

@andrewserong andrewserong force-pushed the try/add-breadcrumbs-block branch from 8c8a048 to 34b3091 Compare August 19, 2021 02:44
@andrewserong
Copy link
Contributor Author

I had a bit of time at the end of the week to make a couple of additions to the PR (thanks again for the feedback, Paal!):

  • Added "Show site title" option
  • Added "Site title override" option that's only visible when "Show site title" is selected
  • Got the above to render correctly in the editor and in the PHP server-rendering
  • Renamed the panel heading to "Breadcrumbs"

Here's how it looks now in the editor:

image

I'm sure there'll be some tweaks needed, but it feels nice having the site title in there now. I'll be working on other things next week, but hope to pick this PR up again after that!

@andrewserong andrewserong added the [Status] In Progress Tracking issues with work in progress label Aug 20, 2021
@paaljoachim
Copy link
Contributor

paaljoachim commented Aug 22, 2021

Looks good Andrew!

Retesting.
on - Show leading seperator
on - Show current page title
on - Show site title

Screen Shot 2021-08-22 at 14 05 54

I changed the home page to Front page.

Even though underlines should be in place because of accessibility it would be nice to have an option to turn these off.
Here is an associated PR.
Post Title Block: add typography formatting options
#31623

Here is an example from my dev site where I am recreating the main site:
https://new.easywebdesigntutorials.com/design-ui-ux-resources/

Screen Shot 2021-08-22 at 14 08 48

Here we can see none active links green while the active link contains the default black color. NB. It also uses all capital letters which I assume will be in the typography controls.
Should there be a way to add colors to active and none active links? Similar to the above example.
Here is an associated PR.
[WIP] Block Support: Custom secondary colors support
#33157

@andrewserong
Copy link
Contributor Author

Great suggestions, thanks for testing again, Paal! Yes, I think it'd be great to be able to control the display of underlines and custom secondary colors to support those sorts of designs, I imagine they'll be very common patterns. I'll dive in when I can circle back to this PR 🙂

@andrewserong andrewserong force-pushed the try/add-breadcrumbs-block branch from 4cefa11 to 826c7b1 Compare September 17, 2021 04:42
@andrewserong
Copy link
Contributor Author

Just pushed a small update to opt the block in to the font weight, style, and text transform typography controls. This gives a bit more flexibility to the variety of designs the block can support, from the creative to the slightly obnoxious 😄. Here's what it currently looks like:

image

For the underline, it'll be great to be able to control it. I see there's an open WIP PR in #31768 to add in that typography control, too.

@paaljoachim
Copy link
Contributor

paaljoachim commented Sep 17, 2021

Awesome work Andrew! This is looking better and better! Thank you!

I am doing some testing.
At the moment it looks like the "Show site title" is not being seen.
Also align Center freezes the Change text Alignment to center.

Alignment: center. Text alignment does not work.
Screenshot 2021-09-17 at 13 32 06

Show site title. Looks like it is not working, as it is not showing the Front page title I set. Also removing the custom Site title does not automatically add in the Home title.

Screenshot 2021-09-17 at 13 32 35

O btw
I am not seeing the Border settings panel.
Screenshot 2021-09-17 at 13 36 08

I am testing with downloading the special PR Gutenberg build.

@andrewserong
Copy link
Contributor Author

Thanks for the additional testing @paaljoachim, much appreciated!

Also align Center freezes the Change text Alignment to center.

I've pushed an update to the block.json file to only opt the block in to the wide and full alignments, so that the left/center/right alignments are handled by the text alignment control instead. This should avoid the situation where you can get stuck using the block-level center alignment, and makes the block more consistent with similar blocks like Post Title.

I am not seeing the Border settings panel.

I believe border controls are only displayed on themes that use a theme.json file and opt-in to that block support. TT1-Blocks uses the following in its settings key, which switches on the border control, and so exposes it on this block, too:

Show site title. Looks like it is not working, as it is not showing the Front page title I set. Also removing the custom Site title does not automatically add in the Home title.

Very strange! I haven't been able to replicate this yet in my test environment, but I'll do some more digging. Can you please share the following:

  • In your test site, what is the name that the site is currently set to? E.g. the Site Title under /wp-admin/options-general.php
  • Which theme are you currently using for testing?

Thanks again, it's very helpful having someone test this out while I'm tinkering away at this PR! 🙇

@andrewserong
Copy link
Contributor Author

I've just pushed a change to explore adding in support for post categories, too. The logic now attempts to use the post/page hierarchy if available and then, if not available, it'll fall back to attempting to use the first category attached to the post. Here's how it looks in TT1-blocks currently on a post with a hierarchical category added:

image

In the above screenshot, the hierarchy goes:

  1. Site title
  2. Travel (parent category)
  3. Australia (sub-category of "Travel" category)
  4. Current post title

With the additional logic, some of the functions are now getting a little long, so before this PR comes out of Draft and when it's a little further along, I might spend some time cleaning / tightening up the code.

@paaljoachim
Copy link
Contributor

Hello Andrew

I've pushed an update to the block.json file to only opt the block in to the wide and full alignments, so that the left/center/right alignments are handled by the text alignment control instead. This should avoid the situation where you can get stuck using the block-level center alignment, and makes the block more consistent with similar blocks like Post Title.

Example the Heading block has a wide and full alignment and can also align text left, center or right.

Screenshot 2021-09-20 at 08 08 33

We should actually do the same for the Paragraph block as is done for the Heading block. Seeing the wide/full alignment and text alignment I thought that was a good idea as it would give better alignment options just like the Header block. One can e.g. have a wide block with a wide background color, a border with a color and border radius. Within this wide box one can then align the text. The text alignment should be spread out to more blocks, as it gives additional customization options for the user.

I believe border controls are only displayed on themes that use a theme.json file and opt-in to that block support. TT1-Blocks uses the following in its settings key, which switches on the border control, and so exposes it on this block, too:

Example the Buttons block as a Border and Dimensions panels.
Screenshot 2021-09-20 at 08 12 18

I am using the theme Twenty Twenty One.
Gutenberg plugin 11.5.0
WordPress 5.8.1

Site URL:
Screenshot 2021-09-20 at 08 14 23

AHA! I see the Site Title is blank. Well that is a good explanation to why it is not working. (I will retest again at a later time to really see that not having a Site Title also breaks the site title feature in Breadcrumbs.)

@andrewserong
Copy link
Contributor Author

Thanks for the extra info! Glad we got to the bottom of the site title issue, perhaps we can add some error handling in the Breadcrumbs UI for the site title to handle the case that the site title is empty 👍

@andrewserong
Copy link
Contributor Author

Example the Heading block has a wide and full alignment and can also align text left, center or right.

Just to clarify, this PR now behaves like the Heading block. The block-based alignment allows for wide and full, and a separate text alignment control allows left, center and right. I think the buggy behaviour was due to the block-level alignment for left/center/right overriding the text alignment, so this PR now behaves more like the Heading block for consistency.

@andrewserong
Copy link
Contributor Author

andrewserong commented Sep 20, 2021

@paaljoachim just a follow-up on the border controls. In Gutenberg, the base theme.json provides default settings that all themes can inherit from. For the Button block, it's set to display the radius control by default across all themes, unless the theme opts-out of it. It's set by default on this line. The current blocks where the border controls are displayed by default are "Button" (just the custom radius), and "Pull quote" (color, radius, style, and width). (This is why we can use these controls on the TwentyTwentyOne theme even though it lacks its own theme.json file)

Once the UI for the border controls stabilises, I believe the plan is to switch many more blocks over to displaying the UI controls by default (which would ultimately also include this block). This PR uses the same block supports mechanism to opt-in to the controls as the Button block does, so if and when this PR lands, we'll be able to go through a similar process and add a small follow-up PR to switch on the controls by default across all themes.

In the mean-time, themes can opt-in to experimental controls, so I typically use TT1-Blocks as my testing theme (and manually edit the theme.json as I go) as it's a good way to test out these features before they stabilise.

@paaljoachim
Copy link
Contributor

Thanks for the clarifications Andrew!

@paaljoachim
Copy link
Contributor

Hey Andrew. I am working on a client site that uses ThemeX and their page builder Cornerstone. I am right now adding in breadcrumbs. This is what it looks like there.

For inspiration.

Home Link -Text-
Screenshot 2021-09-30 at 13 50 29

Home Link -Icon-
Screenshot 2021-09-30 at 13 50 37

@andrewserong
Copy link
Contributor Author

Fantastic, thanks for the screenshots, Paal! Great to see an example of how others manage a UI for selecting icons, that looks like a neat way to handle it. I like the detail that even if "Icon" is selected, the label is still editable, too (I assume for accessibility).

@paaljoachim
Copy link
Contributor

paaljoachim commented Oct 11, 2021

Hey Andrew @andrewserong
From earlier testings I believe we are at a point where we can call this the first version of the Breadcrumbs block, or is there something missing that we should have included?
(Later on I will retest.)

@andrewserong andrewserong force-pushed the try/add-breadcrumbs-block branch from 1c1435c to d757a12 Compare June 5, 2023 03:02
@andrewserong andrewserong added [Type] Experimental Experimental feature or API. and removed [Status] In Progress Tracking issues with work in progress labels Jun 5, 2023
@andrewserong
Copy link
Contributor Author

Thanks for the ping @masteradhoc! Unfortunately I haven't had much time to dust off this PR over the past few WP releases as there have been higher priority features and fixes to work on. I'm not sure how much time I'll have to continue working on this PR, but I've at least given this a rebase and fixed up a few linting issues, and I'll switch this over to ready for review.

It could probably use a fresh pair of eyes to test out the current state of the feature, and whether it's a good enough shape for a v1 for core. I'm aware there are lots of plugins that implement Breadcrumbs features, so I'd be curious to hear what folks think might make for a good core version that balances most-needed features without being too opinionated. For example, the current PR adds schema.org markup to the output so that it (hopefully) plays nicely with search engine results, but I'm not too sure if it's a good inclusion for a v1.

@andrewserong andrewserong marked this pull request as ready for review June 5, 2023 04:29
@aristath
Copy link
Member

aristath commented Jun 6, 2023

I just did a quick scan of the code so it can't count as a "review", but I do have a couple of notes:

  • I'd like to see a filter, to allow changing the $breadcrumbs array. This way plugins like WooCommerce and others can just filter the array of breadcrumbs so that the path is OK for all scenarios. This would be a good way to future-proof the implementation, and keep the Core block minimal.
  • Ideally we wouldn't want to hardcode the itemtype="https://schema.org/BreadcrumbList" in the list. This is a really old method of declaring schema props and in the SEO industry, is sort of considered deprecated. Most SEO plugins generate JSON-LD data, so with this block they'll be able to hook to render_block, check if the block is a breadcrumb, then add a hook in the $breadcrumbs array and generate the proper JSON-LD for the frontend. If however, we have the schema itemtype hardcoded, then we run the risk of search engines detecting duplicate breadcrumbs etc. It would ultimately cause more harm than good.

@paaljoachim
Copy link
Contributor

Using gutenberg.run to test the most recent version.
It looks like this:
Screenshot 2023-06-06 at 16 00 54

It looks like a good first version!
I will ping
@WordPress/gutenberg-design for a look.

I really look forward to having a Breadcrumbs block available in Gutenberg!

@jameskoster
Copy link
Contributor

jameskoster commented Jun 6, 2023

I don't know that I'd make this block available in the post editor, it feels more like a theme/template feature to me. In that respect I'd expect it to not only support pages, but posts and taxonomies too.

In terms of display options, the following are common requests from WooCommerce users:

  • Change the label of the home item (site title makes sense as default, but folks often preferred a simple "Home" or even just a 🏠 icon).
  • Customise the separator appearance (unsure if there are guidelines around this – it may work better as a filter).

@andrewserong
Copy link
Contributor Author

I just did a quick scan of the code so it can't count as a "review", but I do have a couple of notes:

Wonderful, thank you for the feedback @aristath, that's exactly the kind of insight I was after! 🙇 Deferring to plugins for SEO support sounds much better, and good to know that adding in a filter should make this straightforward. Also, thanks for the info about microdata vs JSON-LD — I knew the latter was more common, but didn't realise the former was effectively deprecated / an old way of doing things 👍

I've removed the schema.org markup and added a filter for $breadcrumbs — let me know if you think we need to pass the filter any more info, e.g. the full block object.

I don't know that I'd make this block available in the post editor, it feels more like a theme/template feature to me. In that respect I'd expect it to not only support pages, but posts and taxonomies too.

Thanks @jameskoster, yes, I was imagining it only available in the site editor — I've pushed an update for that. The current feature set will support both posts and pages. It checks if we're in a hierarchical post type (e.g. pages) and uses that hierarchy, and if not, falls back to using hierarchical categories as in posts. I could imagine potentially adding in custom taxonomies in a follow-up for other use cases?

In terms of display options, the following are common requests from WooCommerce users:

  • Change the label of the home item (site title makes sense as default, but folks often preferred a simple "Home").
  • Customise the separator appearance (unsure if there are rules around this – it may work better as a filter).

Good to know! In the current state of this PR folks can edit both of these by clicking into them within the editor canvas (for the separator character that means typing in a different character for it), so good to know we've (at least partially) covered those bases.

@jasmussen
Copy link
Contributor

Nice work. One important aspect of any new block we introduce is to boost the confidence that we actually want it and need it, because they are easy to add, hard to remove.

@masteradhoc
Copy link
Contributor

@andrewserong
Thanks for the work and updates! Looks very good! i think its important to also pass by default the breadcrumb schema. ofc we should allow external plugins to modify but this is definately something that will help a lot of sites just by default and there shouldnt be a need of a seperate plugin or modifications to pass a schema in my opinion :)

@andrewserong
Copy link
Contributor Author

andrewserong commented Jun 7, 2023

One important aspect of any new block we introduce is to boost the confidence that we actually want it and need it, because they are easy to add, hard to remove.

Very good point! Happy to hear feedback from folks as to whether or not, on balance, this is appropriate as a new core block.

i think its important to also pass by default the breadcrumb schema.

Thanks for the feedback! I think @aristath outlined well some of the challenges with including the breadcrumb schema in the core block. We currently don't appear to do this for any other core blocks, and to Joen's point about things being easy to add but hard to remove, it could be difficult to remove schema markup after the fact if we wanted to remove it, but would be much easier to add it in a follow up if it turns out that we do need it. So, I think I probably lean toward not including the schema markup for a v1 of the block. It'd then be possible to open follow-ups that explore potentially adding in schema markup (or JSON) to the output, if need be.

I think part of the challenge of this PR in general has been to come up with a good set of defaults that makes for a simple, usable and useful block for most cases, while being flexible enough to be extended and improved over time. Again, please do share any and all feedback! I'll chip away at any feedback and ideas as I have time 🙂

@QROkes
Copy link

QROkes commented Jun 28, 2023

It makes no sense to have breadcrumbs without the proper markup.
By the way, schema markup (microdata) is old but not deprecated!

Reference: https://developers.google.com/search/docs/appearance/structured-data/breadcrumb

SEO plugins have their own Breadcrumbs block, so it's important this core block has the minimal markup required. They will not filter this block to add it!

Just for reference, here is what SEO plugins are doing:

@paaljoachim
Copy link
Contributor

Hey @andrewserong
I look forward to the continuation of the work happening with the Breadcrumbs block.
Thanks!

@andrewserong
Copy link
Contributor Author

Thanks for the ping, Paal!

Just an update: unfortunately I don't currently have time to continue working on the Breadcrumbs block PR for now, as I've switched to working on other priorities that have design consensus. Before picking this PR back up again, we probably need a decision to be made on the desired scope from a design angle / what folks can agree would be a good MVP for the block in the plugin.

If / when that decision is made, it might be worth dusting this PR off again after WP 6.4 and seeing if it could be made viable again.

Thanks for everyone's continued enthusiasm for the feature! 🙂

@paaljoachim
Copy link
Contributor

@jameskoster @jasmussen @richtabor
Now that WP 6.4 has been released. Let's look at the first version of the Breadcrumbs block and get it out into the wild..:)
Thanks!

@jarekmorawski
Copy link
Contributor

Interesting discussion! There's a clear interest in a Breadcrumbs block. I'm not sure it should be part of the core suite, but there's a chance it could be added when someone browses patterns or blocks in the Inserter (related: #61504).

After some internal discussion, I put together a design that I hope balances customizability and simplicity. I imagine it'd be extensible, meaning third parties could add custom settings and options (like icons or a new toggle to display the home link as an icon).

Block

The block would consist of links to pages, navigation levels, taxonomies, etc. Using the toolbar, users could set the justification, alignment, and width—same as with the Group block and its variants.

Layout

The same settings would also be available in the Inspector. There'd be a new option for Width to allow users to enter a custom width in pixels or other units.

Width

Users would go to Inspector to customize the block's appearance and behavior. When they enable "Show home link", the block will display a link to the home page and users will see an input field in the Inspector. It will allow them to customize the name of the home link. It'd default to the site name but users could enter anything, e.g., Home or Store.

Home

Users could click the ellipsis menu to access more settings, like the current page toggle and a navigation level slider.

More

When the current page toggle is on, the block will display the name of the currently viewed page as the last breadcrumb level. It will not be active, so it wouldn't have the underline like other breadcrumbs. Users could change its appearance under Color in the Style tab.

Current page

The Max. navigation level slider would let users decide when breadcrumbs should be truncated. If moved to the left, the block would display ... in place of the truncated links. Note that the slider would define the maximum number of levels to show, so if there are fewer links, we'd show them all.

Max levels

Users could change the separator in the Styles tab. Of all the dozens of websites I checked, all used one of the three options I included in the design. It could be a good starting point and if users ever need something else, they'd install a plugin that extends the block.

I also included a toggle for displaying the leading separator and reworded the copy a bit, though I'd argue the pattern isn't common enough to be part of the block's default setup. Happy to keep it in the design if you feel it's valuable.

Separator

Once again, users could change the separator color in the Color section.

Color

Let me know if you have any thoughts!

Copy link

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Unlinked Accounts

The following contributors have not linked their GitHub and WordPress.org accounts: @QROkes, @jarekmorawski, @BrunoAHVincent, @rodolfomartinez.

Contributors, please read how to link your accounts to ensure your work is properly credited in WordPress releases.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Unlinked contributors: QROkes, jarekmorawski, BrunoAHVincent, rodolfomartinez.

Co-authored-by: andrewserong <[email protected]>
Co-authored-by: paaljoachim <[email protected]>
Co-authored-by: karmatosed <[email protected]>
Co-authored-by: talldan <[email protected]>
Co-authored-by: masteradhoc <[email protected]>
Co-authored-by: aristath <[email protected]>
Co-authored-by: jameskoster <[email protected]>
Co-authored-by: jasmussen <[email protected]>
Co-authored-by: sybrew <[email protected]>
Co-authored-by: syhussaini <[email protected]>
Co-authored-by: justintadlock <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Design Feedback Needs general design feedback. New Block Suggestion for a new block [Type] Experimental Experimental feature or API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New Breadcrumbs Block
10 participants