Fix centered legacy button. #23381
Fix centered legacy button. #23381
Conversation
|
Size Change: +384 B (0%) Total Size: 1.13 MB
ℹ️ View Unchanged
|
| @@ -18,6 +18,16 @@ | |||
| } | |||
| } | |||
|
|
|||
| .wp-block-buttons.alignleft .wp-block-button { | |||
There was a problem hiding this comment.
do we need this since it's the default style if we don't have alignments?
There was a problem hiding this comment.
Yes because the default in RTL settings is right aligned.
There was a problem hiding this comment.
But wouldn't the style be flipped in the RTL mode?
There was a problem hiding this comment.
No, the alignment buttons are the specific exception because the class names are explicitly set.
There was a problem hiding this comment.
Does this mean we need to wrap these with /*!rtl:begin:ignore*/ ?
There was a problem hiding this comment.
MAYBE.
Yes. Actually it does. On it.
|
@kjellr I bundled some RTL / alignment fixes in this patch. Can you sanity check them? |
|
I think the RTL alignments are still broken. I think if we don't flip the styles automatically, first-child should be last-child... |
|
Good catch. I think the last one got it? |
There was a problem hiding this comment.
This seems to work on my end. The RTL styles look right in Twenty Nineteen:
When using the Gutenberg Starter Theme, the right alignment didn't seem to work on the front end, but I think that's just a bug with the theme. In any case, that existed before this PR. 👍
kjellr
added
the
[Feature] Themes
|
Ah wait, I think I missed something — Check out the margins for left/right items when RTL styles are active in that screenshot. I think Riad's note above is still valid. |
|
Ack, I'll make a follow-up. |
Fixes #23291.
The legacy button (singular) block could not be centered.
Before:
After:
This PR also adds an explicit "align left" rule for the Buttons (plural) block, which matters in RTL contexts.