Update post/page related functions to return ID as number

WordPress · Dec 17, 2024 · ba6868a · ba6868a
1 parent 9e4ceb6
commit ba6868a
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 5 deletions.
diff --git a/packages/core-data/src/private-selectors.ts b/packages/core-data/src/private-selectors.ts
@@ -119,7 +119,7 @@ export function getRegisteredPostMeta( state: State, postType: string ) {
 	return state.registeredPostMeta?.[ postType ] ?? {};
 }
 
-function normalizePageId( value: number | string | undefined ): string | null {
+function normalizePageId( value: number | string | undefined ): number | null {
 	if ( ! value || ! [ 'number', 'string' ].includes( typeof value ) ) {
 		return null;
 	}
@@ -129,7 +129,11 @@ function normalizePageId( value: number | string | undefined ): string | null {
 		return null;
 	}
 
-	return value.toString();
+	if ( typeof value === 'string' ) {
+		return parseInt( value, 10 );
+	}
+
+	return value;
 }
 
 interface SiteData {

diff --git a/packages/fields/src/fields/template/template-edit.tsx b/packages/fields/src/fields/template/template-edit.tsx
@@ -52,10 +52,9 @@ export const TemplateEdit = ( {
 				select( coreStore )
 			);
 
-			const isPostsPage = getPostsPageId() === postId.toString();
+			const isPostsPage = getPostsPageId() === postId;
 			const isFrontPage =
-				postType === 'page' &&
-				getHomePage()?.postId === postId.toString();
+				postType === 'page' && getHomePage()?.postId === postId;
 
 			return {
 				templates: allTemplates,