By nesting the new key in supports we can dispense with the Reflect.o…

…wnKeys checks
WordPress · Dec 20, 2024 · 31cdc45 · 31cdc45
1 parent e414b83
commit 31cdc45
Show file tree

Hide file tree

Showing 4 changed files with 14 additions and 16 deletions.
diff --git a/packages/block-library/src/query/index.js b/packages/block-library/src/query/index.js
@@ -77,7 +77,10 @@ export default function addDisplayKeyToBlockMetadata(
 	}
 	return {
 		...blockSettings,
-		[ blockMetadataDisplayKey ]: { role: 'content' },
+		supports: {
+			...blockSettings.supports,
+			[ blockMetadataDisplayKey ]: { role: 'content' },
+		},
 	};
 }
 

diff --git a/packages/blocks/src/api/registration.js b/packages/blocks/src/api/registration.js
@@ -177,11 +177,9 @@ function getBlockSettingsFromMetadata( { textdomain, ...metadata } ) {
 	];
 
 	const settings = Object.fromEntries(
-		Reflect.ownKeys( metadata )
-			.map( ( key ) => [ key, metadata[ key ] ] )
-			.filter( ( [ key ] ) =>
-				allowedFields.some( ( field ) => field === key )
-			)
+		Object.entries( metadata ).filter( ( [ key ] ) =>
+			allowedFields.includes( key )
+		)
 	);
 
 	if ( textdomain ) {

diff --git a/packages/blocks/src/api/utils.js b/packages/blocks/src/api/utils.js
@@ -374,7 +374,7 @@ export const __experimentalGetBlockAttributesNamesByRole = ( ...args ) => {
 export function isContentBlock( name ) {
 	const blockType = getBlockType( name );
 
-	if ( blockType?.[ blockMetadataDisplayKey ]?.role === 'content' ) {
+	if ( blockType.supports?.[ blockMetadataDisplayKey ]?.role === 'content' ) {
 		return true;
 	}
 

diff --git a/packages/blocks/src/store/reducer.js b/packages/blocks/src/store/reducer.js
@@ -95,17 +95,14 @@ function bootstrappedBlockTypes( state = {}, action ) {
 				}
 			} else {
 				newDefinition = Object.fromEntries(
-					Reflect.ownKeys( blockType )
+					Object.entries( blockType )
 						.filter(
-							( key ) =>
-								blockType[ key ] !== null &&
-								blockType[ key ] !== undefined
+							( [ , value ] ) =>
+								value !== null && value !== undefined
 						)
-						.map( ( key ) => [
-							typeof key === 'symbol'
-								? key
-								: camelCase( key.toString() ),
-							blockType[ key ],
+						.map( ( [ key, value ] ) => [
+							camelCase( key ),
+							value,
 						] )
 				);
 				newDefinition.name = name;