Change bulk editing to opt in

WordPress · Dec 10, 2024 · 0f3c00c · 0f3c00c
1 parent 9ff0ba0
commit 0f3c00c
Show file tree

Hide file tree

Showing 5 changed files with 8 additions and 5 deletions.
diff --git a/packages/dataviews/src/field-types/datetime.tsx b/packages/dataviews/src/field-types/datetime.tsx
@@ -25,4 +25,5 @@ export default {
 	sort,
 	isValid,
 	Edit: 'datetime',
+	supportsBulkEditing: true,
 };
diff --git a/packages/dataviews/src/field-types/index.tsx b/packages/dataviews/src/field-types/index.tsx
@@ -46,5 +46,6 @@ export default function getFieldTypeDefinition( type?: FieldType ) {
 			return true;
 		},
 		Edit: () => null,
+		supportsBulkEditing: false,
 	};
 }
diff --git a/packages/dataviews/src/field-types/integer.tsx b/packages/dataviews/src/field-types/integer.tsx
@@ -31,4 +31,5 @@ export default {
 	sort,
 	isValid,
 	Edit: 'integer',
+	supportsBulkEditing: true,
 };
diff --git a/packages/dataviews/src/field-types/text.tsx b/packages/dataviews/src/field-types/text.tsx
@@ -24,4 +24,5 @@ export default {
 	sort,
 	isValid,
 	Edit: 'text',
+	supportsBulkEditing: true,
 };
diff --git a/packages/dataviews/src/normalize-fields.ts b/packages/dataviews/src/normalize-fields.ts
@@ -64,11 +64,10 @@ export function normalizeFields< Item >(
 			);
 		};
 
-		let supportsBulkEditing = true;
-		// If custom Edit component is passed in we default to false for bulk edit support.
-		if ( typeof field.Edit === 'function' || field.supportsBulkEditing ) {
-			supportsBulkEditing = field.supportsBulkEditing ?? false;
-		}
+		const supportsBulkEditing =
+			field.supportsBulkEditing ||
+			( typeof field.Edit !== 'function' &&
+				fieldTypeDefinition.supportsBulkEditing );
 
 		const render =
 			field.render || ( field.elements ? renderFromElements : getValue );