Only warn when as is undefined

WordPress · Dec 26, 2024 · 0db5a0c · 0db5a0c
1 parent 161b495
commit 0db5a0c
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 12 deletions.
diff --git a/packages/components/src/navigator/navigator-back-button/hook.ts b/packages/components/src/navigator/navigator-back-button/hook.ts
@@ -34,12 +34,14 @@ export function useNavigatorBackButton(
 			[ goBack, onClick ]
 		);
 
-	maybeWarnDeprecated36pxSize( {
-		componentName: 'Navigator.BackButton',
-		__next40pxDefaultSize: otherProps.__next40pxDefaultSize,
-		size: otherProps.size,
-		hint: 'Set the `__next40pxDefaultSize` prop to true to start opting into the new default size, which will become the default in a future version. For icon buttons, consider setting a non-default size like `size: "compact"`.',
-	} );
+	if ( as === undefined ) {
+		maybeWarnDeprecated36pxSize( {
+			componentName: 'Navigator.BackButton',
+			__next40pxDefaultSize: otherProps.__next40pxDefaultSize,
+			size: otherProps.size,
+			hint: 'Set the `__next40pxDefaultSize` prop to true to start opting into the new default size, which will become the default in a future version. For icon buttons, consider setting a non-default size like `size: "compact"`.',
+		} );
+	}
 
 	return {
 		as: as ?? Button,

diff --git a/packages/components/src/navigator/navigator-button/hook.ts b/packages/components/src/navigator/navigator-button/hook.ts
@@ -46,12 +46,14 @@ export function useNavigatorButton(
 			[ goTo, onClick, attributeName, escapedPath ]
 		);
 
-	maybeWarnDeprecated36pxSize( {
-		componentName: 'Navigator.Button',
-		__next40pxDefaultSize: otherProps.__next40pxDefaultSize,
-		size: otherProps.size,
-		hint: 'Set the `__next40pxDefaultSize` prop to true to start opting into the new default size, which will become the default in a future version. For icon buttons, consider setting a non-default size like `size: "compact"`.',
-	} );
+	if ( as === undefined ) {
+		maybeWarnDeprecated36pxSize( {
+			componentName: 'Navigator.Button',
+			__next40pxDefaultSize: otherProps.__next40pxDefaultSize,
+			size: otherProps.size,
+			hint: 'Set the `__next40pxDefaultSize` prop to true to start opting into the new default size, which will become the default in a future version. For icon buttons, consider setting a non-default size like `size: "compact"`.',
+		} );
+	}
 
 	return {
 		as: as ?? Button,