fix: Block focus removed even on clicking the inspector control to add Url #123638
Annotations
4 errors, 2 warnings, and 1 notice
Run the tests:
test/e2e/specs/editor/blocks/navigation.spec.js#L730
1) [chromium] › editor/blocks/navigation.spec.js:318:2 › Navigation block › navigation manages focus for creating, editing, and deleting items
Error: Timed out 5000ms waiting for expect(locator).toBeHidden()
Locator: getByRole('combobox', { name: 'Search or type URL' })
Expected: hidden
Received: visible
Call log:
- expect.toBeHidden with timeout 5000ms
- waiting for getByRole('combobox', { name: 'Search or type URL' })
9 × locator resolved to <input value="" required="" type="text" role="combobox" aria-expanded="false" aria-autocomplete="list" id="url-input-control-1" placeholder="Search or type URL" aria-owns="block-editor-url-input-suggestions-1" class="components-input-control__input fbaa-f-e-a-bc-1p2vxjs em5sgkm3"/>
- unexpected value "visible"
728 | await this.page.keyboard.press( 'Escape' );
729 |
> 730 | await expect( linkControlSearch ).toBeHidden();
| ^
731 | }
732 |
733 | /**
at Navigation.addLinkClose (/home/runner/work/gutenberg/gutenberg/test/e2e/specs/editor/blocks/navigation.spec.js:730:37)
at /home/runner/work/gutenberg/gutenberg/test/e2e/specs/editor/blocks/navigation.spec.js:346:3
|
Run the tests:
test/e2e/specs/editor/blocks/navigation.spec.js#L730
1) [chromium] › editor/blocks/navigation.spec.js:318:2 › Navigation block › navigation manages focus for creating, editing, and deleting items
Retry #1 ───────────────────────────────────────────────────────────────────────────────────────
Error: Timed out 5000ms waiting for expect(locator).toBeHidden()
Locator: getByRole('combobox', { name: 'Search or type URL' })
Expected: hidden
Received: visible
Call log:
- expect.toBeHidden with timeout 5000ms
- waiting for getByRole('combobox', { name: 'Search or type URL' })
2 × locator resolved to <input value="" required="" type="text" role="combobox" aria-expanded="false" aria-autocomplete="list" id="url-input-control-1" placeholder="Search or type URL" aria-owns="block-editor-url-input-suggestions-1" class="components-input-control__input fabd-ab--be-cabcd-1p2vxjs em5sgkm3"/>
- unexpected value "visible"
7 × locator resolved to <input value="" required="" type="text" role="combobox" aria-expanded="true" aria-autocomplete="list" id="url-input-control-1" placeholder="Search or type URL" aria-owns="block-editor-url-input-suggestions-1" class="components-input-control__input fabd-ab--be-cabcd-1p2vxjs em5sgkm3"/>
- unexpected value "visible"
728 | await this.page.keyboard.press( 'Escape' );
729 |
> 730 | await expect( linkControlSearch ).toBeHidden();
| ^
731 | }
732 |
733 | /**
at Navigation.addLinkClose (/home/runner/work/gutenberg/gutenberg/test/e2e/specs/editor/blocks/navigation.spec.js:730:37)
at /home/runner/work/gutenberg/gutenberg/test/e2e/specs/editor/blocks/navigation.spec.js:346:3
|
Run the tests:
test/e2e/specs/editor/blocks/navigation.spec.js#L730
1) [chromium] › editor/blocks/navigation.spec.js:318:2 › Navigation block › navigation manages focus for creating, editing, and deleting items
Retry #2 ───────────────────────────────────────────────────────────────────────────────────────
Error: Timed out 5000ms waiting for expect(locator).toBeHidden()
Locator: getByRole('combobox', { name: 'Search or type URL' })
Expected: hidden
Received: visible
Call log:
- expect.toBeHidden with timeout 5000ms
- waiting for getByRole('combobox', { name: 'Search or type URL' })
3 × locator resolved to <input value="" required="" type="text" role="combobox" aria-expanded="false" aria-autocomplete="list" id="url-input-control-1" placeholder="Search or type URL" aria-owns="block-editor-url-input-suggestions-1" class="components-input-control__input edcee-fb-ef-bb-ffe-1p2vxjs em5sgkm3"/>
- unexpected value "visible"
6 × locator resolved to <input value="" required="" type="text" role="combobox" aria-expanded="true" aria-autocomplete="list" id="url-input-control-1" placeholder="Search or type URL" aria-owns="block-editor-url-input-suggestions-1" class="components-input-control__input edcee-fb-ef-bb-ffe-1p2vxjs em5sgkm3"/>
- unexpected value "visible"
728 | await this.page.keyboard.press( 'Escape' );
729 |
> 730 | await expect( linkControlSearch ).toBeHidden();
| ^
731 | }
732 |
733 | /**
at Navigation.addLinkClose (/home/runner/work/gutenberg/gutenberg/test/e2e/specs/editor/blocks/navigation.spec.js:730:37)
at /home/runner/work/gutenberg/gutenberg/test/e2e/specs/editor/blocks/navigation.spec.js:346:3
|
Run the tests
Process completed with exit code 1.
|
Your workflow is using a version of actions/cache that is scheduled for deprecation, actions/cache@0c45773b623bea8c8e75f6c82b208c3cf94ea4f9. Please update your workflow to use either v3 or v4 of actions/cache to avoid interruptions. Learn more: https://github.blog/changelog/2024-12-05-notice-of-upcoming-releases-and-breaking-changes-for-github-actions/#actions-cache-v1-v2-and-actions-toolkit-cache-package-closing-down
|
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636
|
Run the tests
1 failed
[chromium] › editor/blocks/navigation.spec.js:318:2 › Navigation block › navigation manages focus for creating, editing, and deleting items
1 skipped
209 passed (8.8m)
|
Loading