Skip to content

Fix navigation block inserter behavior: prioritize submenus and disable direct insert. #122754

Fix navigation block inserter behavior: prioritize submenus and disable direct insert.

Fix navigation block inserter behavior: prioritize submenus and disable direct insert. #122754

Triggered via pull request December 24, 2024 07:40
Status Failure
Total duration 18m 21s
Artifacts 2

end2end-test.yml

on: pull_request
Matrix: e2e-playwright
Merge Artifacts
4s
Merge Artifacts
Report to GitHub
0s
Report to GitHub
Fit to window
Zoom out
Zoom in

Annotations

12 errors, 9 warnings, and 8 notices
[chromium] › site-editor/dataviews-list-layout-keyboard.spec.js:96:2 › Dataviews List Layout › Navigates the items list via UP/DOWN arrow keys: test/e2e/specs/site-editor/dataviews-list-layout-keyboard.spec.js#L113
1) [chromium] › site-editor/dataviews-list-layout-keyboard.spec.js:96:2 › Dataviews List Layout › Navigates the items list via UP/DOWN arrow keys Error: Timed out 5000ms waiting for expect(locator).toBeFocused() Locator: getByLabel('Sample Page') Expected: focused Received: inactive Call log: - expect.toBeFocused with timeout 5000ms - waiting for getByLabel('Sample Page') - locator resolved to <button tabindex="-1" type="button" aria-pressed="false" id="view-list-0-177-item-wrapper" class="dataviews-view-list__item" aria-labelledby="view-list-0-177-label" aria-describedby="view-list-0-177-description"></button> - unexpected value "not focused" - locator resolved to <button tabindex="-1" type="button" aria-pressed="false" id="view-list-0-177-item-wrapper" class="dataviews-view-list__item" aria-labelledby="view-list-0-177-label" aria-describedby="view-list-0-177-description"></button> - unexpected value "not focused" - locator resolved to <button tabindex="-1" type="button" aria-pressed="false" id="view-list-0-177-item-wrapper" class="dataviews-view-list__item" aria-labelledby="view-list-0-177-label" aria-describedby="view-list-0-177-description"></button> - unexpected value "not focused" - locator resolved to <button tabindex="-1" type="button" aria-pressed="false" id="view-list-0-177-item-wrapper" class="dataviews-view-list__item" aria-labelledby="view-list-0-177-label" aria-describedby="view-list-0-177-description"></button> - unexpected value "not focused" - locator resolved to <button tabindex="-1" type="button" aria-pressed="false" id="view-list-0-177-item-wrapper" class="dataviews-view-list__item" aria-labelledby="view-list-0-177-label" aria-describedby="view-list-0-177-description"></button> - unexpected value "not focused" - locator resolved to <button tabindex="-1" type="button" aria-pressed="false" id="view-list-0-177-item-wrapper" class="dataviews-view-list__item" aria-labelledby="view-list-0-177-label" aria-describedby="view-list-0-177-description"></button> - unexpected value "not focused" - locator resolved to <button tabindex="-1" type="button" aria-pressed="false" id="view-list-0-177-item-wrapper" class="dataviews-view-list__item" aria-labelledby="view-list-0-177-label" aria-describedby="view-list-0-177-description"></button> - unexpected value "not focused" - locator resolved to <button tabindex="-1" type="button" aria-pressed="false" id="view-list-0-177-item-wrapper" class="dataviews-view-list__item" aria-labelledby="view-list-0-177-label" aria-describedby="view-list-0-177-description"></button> - unexpected value "not focused" - locator resolved to <button tabindex="-1" type="button" aria-pressed="false" id="view-list-0-177-item-wrapper" class="dataviews-view-list__item" aria-labelledby="view-list-0-177-label" aria-describedby="view-list-0-177-description"></button> - unexpected value "not focused" 111 | // Use arrow up/down to move through the list. 112 | await page.keyboard.press( 'ArrowDown' ); > 113 | await expect( page.getByLabel( 'Sample Page' ) ).toBeFocused(); | ^ 114 | 115 | await page.keyboard.press( 'ArrowUp' ); 116 | await expect( page.getByLabel( 'Privacy Policy' ) ).toBeFocused(); at /home/runner/work/gutenberg/gutenberg/test/e2e/specs/site-editor/dataviews-list-layout-keyboard.spec.js:113:52
[chromium] › editor/blocks/navigation.spec.js:203:3 › Navigation block › As a user I want to create submenus using the navigation block › create a submenu: test/e2e/specs/editor/blocks/navigation.spec.js#L228
1) [chromium] › editor/blocks/navigation.spec.js:203:3 › Navigation block › As a user I want to create submenus using the navigation block › create a submenu TimeoutError: locator.click: Timeout 10000ms exceeded. Call log: - waiting for getByRole('button', { name: 'Add submenu' }) 226 | name: 'Add submenu', 227 | } ); > 228 | await addSubmenuButton.click(); | ^ 229 | await page.keyboard.type( '#yup' ); 230 | await page.keyboard.press( 'Enter' ); 231 | at /home/runner/work/gutenberg/gutenberg/test/e2e/specs/editor/blocks/navigation.spec.js:228:27
[chromium] › editor/blocks/navigation.spec.js:203:3 › Navigation block › As a user I want to create submenus using the navigation block › create a submenu: test/e2e/specs/editor/blocks/navigation.spec.js#L228
1) [chromium] › editor/blocks/navigation.spec.js:203:3 › Navigation block › As a user I want to create submenus using the navigation block › create a submenu Retry #1 ─────────────────────────────────────────────────────────────────────────────────────── TimeoutError: locator.click: Timeout 10000ms exceeded. Call log: - waiting for getByRole('button', { name: 'Add submenu' }) 226 | name: 'Add submenu', 227 | } ); > 228 | await addSubmenuButton.click(); | ^ 229 | await page.keyboard.type( '#yup' ); 230 | await page.keyboard.press( 'Enter' ); 231 | at /home/runner/work/gutenberg/gutenberg/test/e2e/specs/editor/blocks/navigation.spec.js:228:27
[chromium] › editor/blocks/navigation.spec.js:203:3 › Navigation block › As a user I want to create submenus using the navigation block › create a submenu: test/e2e/specs/editor/blocks/navigation.spec.js#L228
1) [chromium] › editor/blocks/navigation.spec.js:203:3 › Navigation block › As a user I want to create submenus using the navigation block › create a submenu Retry #2 ─────────────────────────────────────────────────────────────────────────────────────── TimeoutError: locator.click: Timeout 10000ms exceeded. Call log: - waiting for getByRole('button', { name: 'Add submenu' }) 226 | name: 'Add submenu', 227 | } ); > 228 | await addSubmenuButton.click(); | ^ 229 | await page.keyboard.type( '#yup' ); 230 | await page.keyboard.press( 'Enter' ); 231 | at /home/runner/work/gutenberg/gutenberg/test/e2e/specs/editor/blocks/navigation.spec.js:228:27
[chromium] › editor/blocks/navigation.spec.js:318:2 › Navigation block › navigation manages focus for creating: test/e2e/specs/editor/blocks/navigation.spec.js#L726
2) [chromium] › editor/blocks/navigation.spec.js:318:2 › Navigation block › navigation manages focus for creating, editing, and deleting items Error: Timed out 5000ms waiting for expect(locator).toBeFocused() Locator: getByRole('combobox', { name: 'Search or type URL' }) Expected: focused Received: <element(s) not found> Call log: - expect.toBeFocused with timeout 5000ms - waiting for getByRole('combobox', { name: 'Search or type URL' }) 724 | const linkControlSearch = this.getLinkControlSearch(); 725 | > 726 | await expect( linkControlSearch ).toBeFocused(); | ^ 727 | 728 | await this.page.keyboard.press( 'Escape' ); 729 | at Navigation.addLinkClose (/home/runner/work/gutenberg/gutenberg/test/e2e/specs/editor/blocks/navigation.spec.js:726:37) at /home/runner/work/gutenberg/gutenberg/test/e2e/specs/editor/blocks/navigation.spec.js:346:20
[chromium] › editor/blocks/navigation.spec.js:318:2 › Navigation block › navigation manages focus for creating: test/e2e/specs/editor/blocks/navigation.spec.js#L726
2) [chromium] › editor/blocks/navigation.spec.js:318:2 › Navigation block › navigation manages focus for creating, editing, and deleting items Retry #1 ─────────────────────────────────────────────────────────────────────────────────────── Error: Timed out 5000ms waiting for expect(locator).toBeFocused() Locator: getByRole('combobox', { name: 'Search or type URL' }) Expected: focused Received: <element(s) not found> Call log: - expect.toBeFocused with timeout 5000ms - waiting for getByRole('combobox', { name: 'Search or type URL' }) 724 | const linkControlSearch = this.getLinkControlSearch(); 725 | > 726 | await expect( linkControlSearch ).toBeFocused(); | ^ 727 | 728 | await this.page.keyboard.press( 'Escape' ); 729 | at Navigation.addLinkClose (/home/runner/work/gutenberg/gutenberg/test/e2e/specs/editor/blocks/navigation.spec.js:726:37) at /home/runner/work/gutenberg/gutenberg/test/e2e/specs/editor/blocks/navigation.spec.js:346:20
[chromium] › editor/blocks/navigation.spec.js:318:2 › Navigation block › navigation manages focus for creating: test/e2e/specs/editor/blocks/navigation.spec.js#L726
2) [chromium] › editor/blocks/navigation.spec.js:318:2 › Navigation block › navigation manages focus for creating, editing, and deleting items Retry #2 ─────────────────────────────────────────────────────────────────────────────────────── Error: Timed out 5000ms waiting for expect(locator).toBeFocused() Locator: getByRole('combobox', { name: 'Search or type URL' }) Expected: focused Received: <element(s) not found> Call log: - expect.toBeFocused with timeout 5000ms - waiting for getByRole('combobox', { name: 'Search or type URL' }) 724 | const linkControlSearch = this.getLinkControlSearch(); 725 | > 726 | await expect( linkControlSearch ).toBeFocused(); | ^ 727 | 728 | await this.page.keyboard.press( 'Escape' ); 729 | at Navigation.addLinkClose (/home/runner/work/gutenberg/gutenberg/test/e2e/specs/editor/blocks/navigation.spec.js:726:37) at /home/runner/work/gutenberg/gutenberg/test/e2e/specs/editor/blocks/navigation.spec.js:346:20
[chromium] › editor/blocks/navigation.spec.js:527:2 › Navigation block › Adding new links to a navigation block with existing inner blocks triggers creation of a single Navigation Menu: test/e2e/specs/editor/blocks/navigation.spec.js#L580
3) [chromium] › editor/blocks/navigation.spec.js:527:2 › Navigation block › Adding new links to a navigation block with existing inner blocks triggers creation of a single Navigation Menu Error: Timed out 10000ms waiting for expect(locator).toBeVisible() Locator: getByRole('button', { name: 'Dismiss this notice' }) Expected: visible Received: <element(s) not found> Call log: - expect.toBeVisible with timeout 10000ms - waiting for getByRole('button', { name: 'Dismiss this notice' }) 578 | text: 'Navigation Menu successfully created', 579 | } ) > 580 | ).toBeVisible( { timeout: 10000 } ); | ^ 581 | 582 | // The creation Navigation Menu will be a draft 583 | // so we need to check for both publish and draft. at /home/runner/work/gutenberg/gutenberg/test/e2e/specs/editor/blocks/navigation.spec.js:580:5
[chromium] › editor/blocks/navigation.spec.js:527:2 › Navigation block › Adding new links to a navigation block with existing inner blocks triggers creation of a single Navigation Menu: test/e2e/specs/editor/blocks/navigation.spec.js#L580
3) [chromium] › editor/blocks/navigation.spec.js:527:2 › Navigation block › Adding new links to a navigation block with existing inner blocks triggers creation of a single Navigation Menu Retry #1 ─────────────────────────────────────────────────────────────────────────────────────── Error: Timed out 10000ms waiting for expect(locator).toBeVisible() Locator: getByRole('button', { name: 'Dismiss this notice' }) Expected: visible Received: <element(s) not found> Call log: - expect.toBeVisible with timeout 10000ms - waiting for getByRole('button', { name: 'Dismiss this notice' }) 578 | text: 'Navigation Menu successfully created', 579 | } ) > 580 | ).toBeVisible( { timeout: 10000 } ); | ^ 581 | 582 | // The creation Navigation Menu will be a draft 583 | // so we need to check for both publish and draft. at /home/runner/work/gutenberg/gutenberg/test/e2e/specs/editor/blocks/navigation.spec.js:580:5
[chromium] › editor/blocks/navigation.spec.js:527:2 › Navigation block › Adding new links to a navigation block with existing inner blocks triggers creation of a single Navigation Menu: test/e2e/specs/editor/blocks/navigation.spec.js#L580
3) [chromium] › editor/blocks/navigation.spec.js:527:2 › Navigation block › Adding new links to a navigation block with existing inner blocks triggers creation of a single Navigation Menu Retry #2 ─────────────────────────────────────────────────────────────────────────────────────── Error: Timed out 10000ms waiting for expect(locator).toBeVisible() Locator: getByRole('button', { name: 'Dismiss this notice' }) Expected: visible Received: <element(s) not found> Call log: - expect.toBeVisible with timeout 10000ms - waiting for getByRole('button', { name: 'Dismiss this notice' }) 578 | text: 'Navigation Menu successfully created', 579 | } ) > 580 | ).toBeVisible( { timeout: 10000 } ); | ^ 581 | 582 | // The creation Navigation Menu will be a draft 583 | // so we need to check for both publish and draft. at /home/runner/work/gutenberg/gutenberg/test/e2e/specs/editor/blocks/navigation.spec.js:580:5
Playwright - 2
Process completed with exit code 1.
[firefox] › editor/blocks/navigation-frontend-interactivity.spec.js:378:3 › Navigation block - Frontend interactivity › Submenus (Arrow setting) (@firefox: packages/e2e-test-utils-playwright/src/admin/visit-site-editor.ts#L57
1) [firefox] › editor/blocks/navigation-frontend-interactivity.spec.js:378:3 › Navigation block - Frontend interactivity › Submenus (Arrow setting) (@Firefox, @WebKit) › submenu click on the arrow interactions TimeoutError: locator.waitFor: Timeout 60000ms exceeded. Call log: - waiting for locator('.edit-site-canvas-loader, .edit-site-canvas-spinner') to be visible at ../../../packages/e2e-test-utils-playwright/src/admin/visit-site-editor.ts:57 55 | // Wait for the canvas loader to appear first, so that the locator that 56 | // waits for the hidden state doesn't resolve prematurely. > 57 | await canvasLoader.waitFor( { state: 'visible', timeout: 60_000 } ); | ^ 58 | await canvasLoader.waitFor( { 59 | state: 'hidden', 60 | // Bigger timeout is needed for larger entities, like the Large Post at Admin.visitSiteEditor (/home/runner/work/gutenberg/gutenberg/packages/e2e-test-utils-playwright/src/admin/visit-site-editor.ts:57:22) at /home/runner/work/gutenberg/gutenberg/test/e2e/specs/editor/blocks/navigation-frontend-interactivity.spec.js:353:4
Playwright - 6
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636
Playwright - 3
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636
Playwright - 4
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636
Playwright - 5
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636
Playwright - 1
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636
Playwright - 7
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636
Playwright - 2
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636
Playwright - 8
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636
Merge Artifacts
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636
🎭 Playwright Run Summary
2 skipped 195 passed (6.2m)
🎭 Playwright Run Summary
1 skipped 184 passed (8.5m)
🎭 Playwright Run Summary
1 skipped 195 passed (9.7m)
🎭 Playwright Run Summary
1 flaky [chromium] › site-editor/dataviews-list-layout-keyboard.spec.js:96:2 › Dataviews List Layout › Navigates the items list via UP/DOWN arrow keys 1 skipped 199 passed (10.0m)
🎭 Playwright Run Summary
207 passed (10.0m)
🎭 Playwright Run Summary
1 skipped 205 passed (10.5m)
🎭 Playwright Run Summary
3 failed [chromium] › editor/blocks/navigation.spec.js:203:3 › Navigation block › As a user I want to create submenus using the navigation block › create a submenu [chromium] › editor/blocks/navigation.spec.js:318:2 › Navigation block › navigation manages focus for creating, editing, and deleting items [chromium] › editor/blocks/navigation.spec.js:527:2 › Navigation block › Adding new links to a navigation block with existing inner blocks triggers creation of a single Navigation Menu 1 skipped 207 passed (11.1m)
🎭 Playwright Run Summary
1 flaky [firefox] › editor/blocks/navigation-frontend-interactivity.spec.js:378:3 › Navigation block - Frontend interactivity › Submenus (Arrow setting) (@Firefox, @WebKit) › submenu click on the arrow interactions 3 skipped 187 passed (10.8m)

Artifacts

Produced during runtime
Name Size
failures-artifacts
18.2 MB
flaky-tests-report
2.36 KB