Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Eslint stylistic improvements #62

Merged
merged 2 commits into from
Aug 26, 2024

Conversation

ann-kilzer
Copy link
Collaborator

@ann-kilzer ann-kilzer commented Aug 4, 2024

Part of #51

What changed 🧐

  • Add some new eslint rules to remove extra whitespace within and in line ends
  • Add a rule to prevent any type
  • switch from stylistic/ts to the newer stylistic which consolidates all the js ts jsx rules into one package

How did you test it? 🧪

I tested manually by adding code that broke each rule, and then running npm run lint to ensure that the error is caught

  1. Add extra spaces in the middle of a line
  2. Add extra spaces at the end of a line
  3. Define a variable with any type:
let foo: any = 5

@ann-kilzer ann-kilzer self-assigned this Aug 4, 2024
@ann-kilzer ann-kilzer requested a review from sirbully as a code owner August 4, 2024 13:37
Copy link
Contributor

@sirbully sirbully left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 🚀

@ann-kilzer ann-kilzer merged commit 6710a86 into main Aug 26, 2024
5 checks passed
@ann-kilzer ann-kilzer deleted the noissue-eslint-stylistic-improvements branch August 26, 2024 02:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants