Skip to content
This repository has been archived by the owner on Sep 16, 2022. It is now read-only.

Break out CVE to its own page #543

Closed
vpetersson opened this issue Nov 20, 2019 · 7 comments · Fixed by #617
Closed

Break out CVE to its own page #543

vpetersson opened this issue Nov 20, 2019 · 7 comments · Fixed by #617

Comments

@vpetersson
Copy link
Contributor

vpetersson commented Nov 20, 2019

I want to introduce a new CVE page that has a layout similar to this:

High: X Medium: Y Low: Z

CVE Date Package Affected Severity Hosts Affected Solve
CVE-2018-5743 2018-01-17 bind9 Medium 5 Instructions
CVE-2019-11555 2019-04-26 wpa Medium 8 Instructions

Comments:

  • We need to be able to filter and sort by severity and hosts affected.
  • Clicking on instructions should bring up a popover with relevant information.
  • Clicking on host count should bring up a popover with the affected hosts.
  • We need to be able to filter this list by host (just like we do for Recommended Actions) such that we can deep-link to it (see next point).
  • We should replace the Vulnerable Package list on the security tab and instead just have a counter with each type and deep link (E.g. 'High: 5').
  • We need to add a counter next to it in the sidebar (just like Recommended Actions).
  • Sort by Severity (i.e. high, medium low) and number of affected hosts.

Example instructions

Affected package: wpa

Debian instructions

Fix released for:

  • X

Resolution:

$ apt-get update 
$ apt-get install wpa
@vpetersson vpetersson changed the title [WIP] Break out CVE to its own page Break out CVE to its own page Dec 3, 2019
@vpetersson
Copy link
Contributor Author

The current security tab CVE section should be replaced with the following information:

High: $COUNT_OF_HIGH_VULNS_FOR_NODE
Medium: $COUNT_OF_MEDIUM_VULNS_FOR_NODE
Low: $COUNT_OF_LOW_VULNS_FOR_NODE

Detailed view (link to CVE with node filter)

@a-martynovich
Copy link
Contributor

a-martynovich commented Jan 7, 2020

@vpetersson One CVE usually affects several packages. One package may be affected by multiple CVEs. We can't provide common instructions for the hosts which have a different set of packages installed (e.g. one host has only bind9, another has both bind9 and bind9utils), unless we give a really long and cryptic Bash one-liner.
Thus the table may look like this:

CVE Date Severity Package Affected Hosts Affected Solve
CVE-2018-xxx 2018-xx-xx Medium bind9
bind9utils
...
5
4
...
Instructions
Instructions
...
CVE-2017-xxx 2017-xx-xx Medium bind9
bind9utils
...
5
4
...
Instructions
Instructions
...
CVE-2019-xxx 2019-xx-xx Medium ctdb
libnss-winbind
...
6
7
...
Instructions
Instructions
...

we can also make double grouping, this way we save some space:

CVEs Date Severity Package Affected Hosts Affected Solve
CVE-2018-xxx,
CVE-2017-xxx
2018-xx-xx,
2017-xx-xx
Medium bind9
bind9utils
...
5
4
...
Instructions
Instructions
...
CVE-2019-xxx 2019-xx-xx Medium ctdb
libnss-winbind
...
6
7
...
Instructions
Instructions
...

@vpetersson
Copy link
Contributor Author

@a-martynovich Good idea. I think the first grouping is the best way to do it.

@a-martynovich
Copy link
Contributor

@vpetersson when we filter by host, do we need "Hosts Affected" column? If so, what should it contain?

@vpetersson
Copy link
Contributor Author

when we filter by host, do we need "Hosts Affected" column? If so, what should it contain?

It probably makes sense to hide that column when it's in filtered mode.

@a-martynovich
Copy link
Contributor

@vpetersson after completion of #572 and WoTTsecurity/agent#257 we won't need to provide separate instructions for every package, we can instead have one "Instruction" link for a bunch of packages affected by one CVE.

The resulting table will look like this:

CVE Date Severity Package Affected Hosts Affected Solve
CVE-2018-xxx 2018-xx-xx Medium bind9
bind9utils
...
5
4
...
Instructions
CVE-2017-xxx 2017-xx-xx Medium bind9
bind9utils
...
5
4
...
Instructions
CVE-2019-xxx 2019-xx-xx Medium ctdb
libnss-winbind
...
6
7
...
Instructions

@vpetersson
Copy link
Contributor Author

Very nice!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants