Simple Main Menu, Stage Selection, Pause Menu, Game Over Menu #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added Main Menu, Stage Selection, Level w pause menu, Game Over Scenes
Changelogs - Menu.cs Display Game Menu -StageSelection.cs Display Stage Selection Difficulty -Pauser.cs Display Pause menu - Enemies.cs Adjust enemies HP and movement speed to selected stage difficulty - Timer.cs Display Timer/ Gameover when Timer reaches <=0 - PlayerHealth.cs Display Gameover when Health reaches 0 - Gameover.cs Display Gameover Menu
stelcheck
reviewed
May 28, 2018
| ren = transform.Find("body").GetComponent<SpriteRenderer>(); | ||
| frontCheck = transform.Find("frontCheck").transform; | ||
| score = GameObject.Find("Score").GetComponent<Score>(); | ||
| switch (StageSelection.Difficulty) |
There was a problem hiding this comment.
Wouldn't it make more sense to make StageSelection.Difficulty an enum instead of a string?
| { | ||
| const int width = 120, height = 60; | ||
|
|
||
| Rect buttonRect = new Rect(Screen.width / 2 - (width / 2), (2 * Screen.height / 3) - (height / 2), width, height); |
There was a problem hiding this comment.
Dynamic sizing is present in a few places in the code you submitted, would there be a way to abstract the calculation somewhere so to increase the code's readability?
|
|
||
| public class Timer : MonoBehaviour { | ||
|
|
||
| public float TimeLeft; |
There was a problem hiding this comment.
Would it be better to make TimeLeft an integer and cast when subtracting the delta instead? Would it help readability?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.