Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to disable spawnv define #301

Merged
merged 2 commits into from
Sep 21, 2023

Conversation

JorisGoosen
Copy link
Contributor

Helps UCRT mingw users workaround the problem mentioned in #300

@JorisGoosen
Copy link
Contributor Author

@evanmiller ?

@evanmiller
Copy link
Contributor

I would prefer to have the script detect the platform and do the right behavior, rather than add an option.

@JorisGoosen
Copy link
Contributor Author

I would prefer to have the script detect the platform and do the right behavior, rather than add an option.

Fair enough, Ill have a look

@JorisGoosen
Copy link
Contributor Author

The new configure doesnt require a manual option anymore, I tested it on Mingw x64 and Mingw UCRT x64 and it now configures and compiles on both without a hitch

@evanmiller
Copy link
Contributor

There's probably a cleaner way to do this with autconf (see https://stackoverflow.com/questions/46704731/check-value-of-c-define-with-autoconf) but this seems good enough for now, thanks

@evanmiller evanmiller merged commit 4926250 into WizardMac:dev Sep 21, 2023
13 checks passed
@JorisGoosen
Copy link
Contributor Author

Ah yeah that SO answer looks cleaner for sure, but thanks for merging it anyway. It will make our build process much smoother.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants