Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Iframe clean #88

Open
wants to merge 6 commits into
base: dev40
Choose a base branch
from
Open

Iframe clean #88

wants to merge 6 commits into from

Conversation

xmontana
Copy link

@xmontana xmontana commented Nov 24, 2023

Format text summary and fullsummary allowing trusted text like <iframe> if enabletrusttext is enabled. Related to issue #87

@institut-agro-ead
Copy link

The use of format_text for summary and fullcontent has been added with v4.1.4 but seems to be useless ?
format_text is already called in moodle core via $this->courseformatdatacommontrait->course_section_cm_text or $renderer->format_summary_text meaning the module content is already formatted once (with noclean option set to true) then the result is once again formatted without the noclean option. Iframes disappear, so H5Ps embeded inside labels via the H5P button inside text editor don’t show.
Basically, I think those lines should simply be removed as they weren’t here before v4.1.4 and seem to be redundant.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants