Dev #1
Merged
Dev #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shruti-wisdm
reviewed
Sep 3, 2024
| 'type' => 'success', | ||
| ) | ||
| ); | ||
| } else { |
| if ( isset( $_POST['nonce'] ) && ! wp_verify_nonce( sanitize_key( $_POST['nonce'] ), 'mark_complete_nonce' ) ) { | ||
| wp_send_json_error( | ||
| array( | ||
| 'message' => __( 'Please provide proper nonce', 'ld_custom_auto_complete' ), |
There was a problem hiding this comment.
If this message is available to end users, a filter for the message can be added.
| */ | ||
| public function ld_custom_autocomplete_topic( $post_id, $course_id, $user_id ) { | ||
| $is_autocomplete_on = get_post_meta( $post_id, LD_CUSTOM_AUTO_COMPLETE_META, true ); | ||
| if ( 'on' === $is_autocomplete_on ) { |
There was a problem hiding this comment.
Early return is possible
| function () { | ||
| if ( jQuery( '.learndash_timer' ).length ) { | ||
| jQuery( '.learndash_timer' ).each( | ||
| function ( idx, item ) { |
There was a problem hiding this comment.
Add comments for the functions. Also, variable names need to reflect what they represent
| @@ -0,0 +1,35 @@ | |||
| <?php | |||
There was a problem hiding this comment.
Is this file still required?
| */ | ||
| public function ld_custom_autocomplete_add_setting( $setting_option_fields = array(), $settings_metabox_key = '' ) { | ||
|
|
||
| if ( 'learndash-topic-display-content-settings' === $settings_metabox_key || 'learndash-lesson-display-content-settings' === $settings_metabox_key ) { |
| ); | ||
| $help_text = sprintf( | ||
| // translators: placeholder: lesson. | ||
| esc_html_x( 'Turning this on will allow you to autocomplete %s.', 'placeholder: Lesson.', 'learndash' ), |
There was a problem hiding this comment.
The text domain is incorrect. Generate a pot file and confirm whether all the strings show up for translation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.