Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merging kohei0302/WiringPi-Node #82

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

NoHomey
Copy link
Collaborator

@NoHomey NoHomey commented Sep 8, 2017

Merging changes from @kohei0302.

@NoHomey NoHomey requested a review from nekuz0r September 8, 2017 06:08
DOCUMENTATION.md Outdated
<span class="api-info-list"><code> >= 2.1.0 </code></span>
* `PI_MODEL_3`
<span class="api-info-list"><code> >= 2.1.0 </code></span>
* `PI_MODEL_ZERO`
Copy link
Collaborator

@nekuz0r nekuz0r Sep 8, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since new constants are added the version should be bumped, and the documentation should reflect it accordingly.

Also since some are renamed/removed, it's a breaking change, i suggest 2.2.0 then

@kohei0302
Copy link

Hi

It’is not important that this pull request.
We should discuss below pull request.

nekuz0r/wiringpi#5

@nekuz0r
Copy link
Collaborator

nekuz0r commented Sep 8, 2017

@kohei0302 I reviewed the other pull request, once merged, please update this one to point back to the original repository, and address the requested changes.
Also, make sure to squash your commits.

@kohei0302
Copy link

@nekuz0r
This version is "2.2.0".
What is the next version?

@nekuz0r
Copy link
Collaborator

nekuz0r commented Sep 9, 2017

If we want to keep semver 3.0.0

@kohei0302
Copy link

I fixed document and changed the URL of clone.

git clone https://github.com/nekuz0r/wiringpi.git -b v2.44 --depth 1

Please merge and make tag properly.
I suggest tag version to be v2.44.

@nekuz0r
Copy link
Collaborator

nekuz0r commented Sep 19, 2017

@kohei0302 still waiting for comment on nekuz0r/wiringpi#5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants