-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merging kohei0302/WiringPi-Node #82
base: master
Are you sure you want to change the base?
Conversation
DOCUMENTATION.md
Outdated
<span class="api-info-list"><code> >= 2.1.0 </code></span> | ||
* `PI_MODEL_3` | ||
<span class="api-info-list"><code> >= 2.1.0 </code></span> | ||
* `PI_MODEL_ZERO` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since new constants are added the version should be bumped, and the documentation should reflect it accordingly.
Also since some are renamed/removed, it's a breaking change, i suggest 2.2.0
then
Hi It’is not important that this pull request. |
@kohei0302 I reviewed the other pull request, once merged, please update this one to point back to the original repository, and address the requested changes. |
@nekuz0r |
If we want to keep semver |
I fixed document and changed the URL of clone. git clone https://github.com/nekuz0r/wiringpi.git -b v2.44 --depth 1 Please merge and make tag properly. |
@kohei0302 still waiting for comment on nekuz0r/wiringpi#5 |
Merging changes from @kohei0302.