do not cleanup command if there is no shell #316
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses a scenario introduced in #315 where another thread calls
closeon a shell while a long running command is running and then when the thread running the command experiences an exception when it attempts to send a cleanup/termination command on a closed shell.This PR addresses the exception but does not truly fix the above issue since it still does not allow a way to send a terminate message on an existing command. We would need to do some deeper refactoring to support that.
It's important to note here that closing a shell while a command is running may cause that command to run indefinitely on the remote machine.
Signed-off-by: mwrock [email protected]