Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(wb): refer to HOST environment variable when opening browser #218

Merged
merged 1 commit into from
Jan 16, 2024

Conversation

reminjp
Copy link
Member

@reminjp reminjp commented Jan 16, 2024

現状では、wb startを実行するとアプリが起動した後ブラウザでhttp://localhost:{port}が開かれます。

しかし、WillBoosterの一部のプロジェクトでは、Cookieを正しく扱うためにhttp://localhost:3000でなくhttp://localhost-{プロジェクトによって異なる文字列}.willbooster.net:3000を開かねばなりません。

このPRでは、ブラウザで開かれるURLのホストを環境変数を介して指定できるようにします。

Self Check

  • I've confirmed All checks have passed on PR page. (You may leave this box unchecked due to long workflows.)
    • PR title follows Angular's commit message format.
      • PR title doesn't have WIP:.
    • All tests are passed.
      • Test command (e.g., yarn test) is passed.
      • Lint command (e.g., yarn lint) is passed.
  • I've reviewed my changes on PR's diff view.

@reminjp reminjp requested a review from exKAZUu January 16, 2024 02:46
@reminjp reminjp self-assigned this Jan 16, 2024
@reminjp reminjp changed the title feat: refer to HOST environment variable when opening browser feat(wb): refer to HOST environment variable when opening browser Jan 16, 2024
Copy link
Member

@exKAZUu exKAZUu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@exKAZUu exKAZUu merged commit 5c0f10b into main Jan 16, 2024
9 checks passed
@exKAZUu exKAZUu deleted the feat-open-host branch January 16, 2024 03:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants