-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update workflow to Python 3.12 #539
Conversation
Cap numpy<2 Bump rasterio to v1.4.3, pyproj to v3.7
With this update the package should pass the Julia Registry QA workflow. |
jinja2>=3.1 | ||
numpy<2.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Interesting, so it turns out you don't have to have numpy 2 for the updated rasterio?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tried to build with numpy 2 but it conflicted with other deps. It seems rasterio is still compatible with numpy 1.
src/latlon.py
Outdated
ys = np.array(ys) | ||
|
||
xs = xs.reshape(im.shape) # needed in rasterio 1.4.3 | ||
ys = ys.reshape(im.shape) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice and clean
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Glad to see it was a simple fix!
This pull request includes updates to the CI workflow and a fix for compatibility with a new version of the
rasterio
library. The most important changes involve updating the Python version and adjusting the code to work with the new library version.CI workflow updates:
.github/workflows/CI.yml
: Updated the Python version from 3.11 to 3.12, added steps to installsetuptools
anduv
for dependency conflict resolution, and modified the requirements installation process to use a compiled requirements file specific to Python 3.12.Library compatibility fix:
src/latlon.py
: Modified thegetlatlon
function to reshape arraysxs
andys
to match the image shape, ensuring compatibility withrasterio
version 1.4.3.